[GitHub] [spark] gengliangwang commented on a change in pull request #24694: [SPARK-27830][CORE][UI] Show Spark version at app lists of Spark History UI

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #24694: [SPARK-27830][CORE][UI] Show Spark version at app lists of Spark History UI
URL: https://github.com/apache/spark/pull/24694#discussion_r287570903
 
 

 ##########
 File path: core/src/main/resources/org/apache/spark/ui/static/historypage.js
 ##########
 @@ -136,7 +140,7 @@ $(document).ready(function() {
             (attempt.hasOwnProperty("attemptId") ? attempt["attemptId"] + "/" : "") + "logs";
           attempt["durationMillisec"] = attempt["duration"];
           attempt["duration"] = formatDuration(attempt["duration"]);
-          var app_clone = {"id" : id, "name" : name, "num" : num, "attempts" : [attempt]};
+          var app_clone = {"id" : id, "name" : name, "version": version, "num" : num, "attempts" : [attempt]};
 
 Review comment:
   I think we can simply use
   ```
   "version": attempt["appSparkVersion"]
   ```
   here.
   
   Any reason we always set the version as the first attempt?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org