You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by GitBox <gi...@apache.org> on 2020/04/16 07:16:04 UTC
[GitHub] [jclouds] felfert opened a new pull request #67: Fix javadoc
generation on JDK >= 8
felfert opened a new pull request #67: Fix javadoc generation on JDK >= 8
URL: https://github.com/apache/jclouds/pull/67
This fixes javadoc generation with JDK >= 8 so that someone with write-permission to the jclouds.apache.org site can fix apache/jclouds-site#12
Note: This also applies to the 2.2.x branch, shall I create another PR for that?
Cheers
-Fritz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] gaul commented on issue #67: Fix javadoc generation on
JDK >= 8
Posted by GitBox <gi...@apache.org>.
gaul commented on issue #67: Fix javadoc generation on JDK >= 8
URL: https://github.com/apache/jclouds/pull/67#issuecomment-614641945
@felfert @nacx Oops I missed that this broke master:
https://builds.apache.org/job/jclouds/101/console
It appears that we build with Java 7 and need some profile selection to fix it. @felfert can you look into this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] nacx commented on issue #67: Fix javadoc generation on
JDK >= 8
Posted by GitBox <gi...@apache.org>.
nacx commented on issue #67: Fix javadoc generation on JDK >= 8
URL: https://github.com/apache/jclouds/pull/67#issuecomment-614592386
>Obviously, this currently does not get validated in travis. I could add a modification to travis.yml, but I'm not shure if that is desired. IMHO, it is better to create another PR after this one gets merged.
+1, that looks good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] felfert commented on issue #67: Fix javadoc generation on
JDK >= 8
Posted by GitBox <gi...@apache.org>.
felfert commented on issue #67: Fix javadoc generation on JDK >= 8
URL: https://github.com/apache/jclouds/pull/67#issuecomment-615109912
@nacx , @gaul
See #68
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] felfert commented on issue #67: Fix javadoc generation on
JDK >= 8
Posted by GitBox <gi...@apache.org>.
felfert commented on issue #67: Fix javadoc generation on JDK >= 8
URL: https://github.com/apache/jclouds/pull/67#issuecomment-614483466
Another note:
Obviously, this currently does not get validated in travis. I could add a modification to travis.yml, but I'm not shure if that is desired. IMHO, it is better to create another PR **after** this one gets merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] felfert commented on issue #67: Fix javadoc generation on
JDK >= 8
Posted by GitBox <gi...@apache.org>.
felfert commented on issue #67: Fix javadoc generation on JDK >= 8
URL: https://github.com/apache/jclouds/pull/67#issuecomment-614765276
Well, on a clean VM with JDK7 (java-1.7.0-openjdk-devel-1.7.0.251-2.6.21.0.el7_7.x86_64)
everything builds fine here. Since I don't have access to your jenkins setup, I can only guess, that this setup might be broken in that respect. In fact, the build log shows, that jdk**1.8** is used to run maven but then this is apparently reverted by using -Pjenkins which activates maven-toolchains-plugin which itself uses **~/.m2/toolchains.xml** to which I don't have access. So my hands are tied here.
=> Can one of you guys can provide me with that file so I can investigate further?
@nacx : Maybe you introduced this jenkins profile for exactly that reason (Use jdk7 in order to solve the javadoc errors with JDK8 on jenkins)? If so, you could simply drop the -Pjenkins argument?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] nacx merged pull request #67: Fix javadoc generation on
JDK >= 8
Posted by GitBox <gi...@apache.org>.
nacx merged pull request #67: Fix javadoc generation on JDK >= 8
URL: https://github.com/apache/jclouds/pull/67
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] felfert commented on issue #67: Fix javadoc generation on
JDK >= 8
Posted by GitBox <gi...@apache.org>.
felfert commented on issue #67: Fix javadoc generation on JDK >= 8
URL: https://github.com/apache/jclouds/pull/67#issuecomment-614680665
Thats strange. I **did** create a profile "disable-doclint" which should get activated by jdk8 only.
Even stranger, in travis.yml it says:
```
jdk:
- openjdk8
```
Well, I guess I have to fetch an old jdk to verify this...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] felfert edited a comment on issue #67: Fix javadoc
generation on JDK >= 8
Posted by GitBox <gi...@apache.org>.
felfert edited a comment on issue #67: Fix javadoc generation on JDK >= 8
URL: https://github.com/apache/jclouds/pull/67#issuecomment-614765276
Well, on a clean VM with JDK7 (java-1.7.0-openjdk-devel-1.7.0.251-2.6.21.0.el7_7.x86_64)
everything builds fine here. Since I don't have access to your jenkins setup, I can only guess, that this setup might be broken in that respect. In fact, the build log shows, that jdk**1.8** is used to run maven but then this is apparently reverted by using -Pjenkins which activates maven-toolchains-plugin which itself uses **~/.m2/toolchains.xml** to which I don't have access. So my hands are tied here.
@gaul @nacx Can one of you guys can provide me with that file so I can investigate further?
@nacx : Maybe you introduced this jenkins profile for exactly that reason (Use jdk7 in order to solve the javadoc errors with JDK8 on jenkins)? If so, you could simply drop the -Pjenkins argument?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] gaul commented on issue #67: Fix javadoc generation on
JDK >= 8
Posted by GitBox <gi...@apache.org>.
gaul commented on issue #67: Fix javadoc generation on JDK >= 8
URL: https://github.com/apache/jclouds/pull/67#issuecomment-614639814
Pushed to 2.2.x as 876269427b80d1d4a68403e0e729342d340fbd82.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services