You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/10/25 06:13:47 UTC

[GitHub] [bookkeeper] Shoothzj opened a new pull request #2845: A empty implment in EtcdLedgerManagerFactory to let the project can compile

Shoothzj opened a new pull request #2845:
URL: https://github.com/apache/bookkeeper/pull/2845


   ### Motivation
   write a empty implement let the project can compile


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2845: A empty implment in EtcdLedgerManagerFactory to let the project can compile

Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2845:
URL: https://github.com/apache/bookkeeper/pull/2845#discussion_r735286963



##########
File path: metadata-drivers/etcd/src/main/java/org/apache/bookkeeper/metadata/etcd/EtcdLedgerManagerFactory.java
##########
@@ -91,6 +92,11 @@ public LedgerUnderreplicationManager newLedgerUnderreplicationManager()
         throw new UnsupportedOperationException();
     }
 
+    @Override
+    public LedgerAuditorManager newLedgerAuditorManager() throws IOException, InterruptedException {
+        return null;

Review comment:
       Can you throw an UnsupportedOperationException?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] Shoothzj commented on pull request #2845: A empty implment in EtcdLedgerManagerFactory to let the project can compile

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #2845:
URL: https://github.com/apache/bookkeeper/pull/2845#issuecomment-950572630


   The problem is introduced in #2842 . Add a method in `LedgerManagerFactory `, but not implemented in `EtcdLedgerManagerFactory`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli merged pull request #2845: A empty implmentation of newLedgerAuditorManager in EtcdLedgerManagerFactory to fix build

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2845:
URL: https://github.com/apache/bookkeeper/pull/2845


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] Shoothzj commented on a change in pull request #2845: A empty implment in EtcdLedgerManagerFactory to let the project can compile

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on a change in pull request #2845:
URL: https://github.com/apache/bookkeeper/pull/2845#discussion_r735287770



##########
File path: metadata-drivers/etcd/src/main/java/org/apache/bookkeeper/metadata/etcd/EtcdLedgerManagerFactory.java
##########
@@ -91,6 +92,11 @@ public LedgerUnderreplicationManager newLedgerUnderreplicationManager()
         throw new UnsupportedOperationException();
     }
 
+    @Override
+    public LedgerAuditorManager newLedgerAuditorManager() throws IOException, InterruptedException {
+        return null;

Review comment:
       Yes, that's better




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org