You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/17 07:19:27 UTC
[GitHub] [arrow-datafusion] waitingkuo opened a new pull request, #3186: add a readme for clickbench intro
waitingkuo opened a new pull request, #3186:
URL: https://github.com/apache/arrow-datafusion/pull/3186
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2902
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
initial work to add datafusion into <https://benchmark.clickhouse.com/>
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3186: add a readme for clickbench intro
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #3186:
URL: https://github.com/apache/arrow-datafusion/pull/3186#discussion_r948033439
##########
clickbench/README.md:
##########
@@ -0,0 +1,52 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Clickbench Benchmark
+
+## Introduction
+
+<https://benchmark.clickhouse.com/> is a new benchmark set provided by ClickHouse. The current result for DataFusion is from Azure's `v16s_v2` VM
+
+
+## The way to reproduce
+
+1. `git clone git@github.com:ClickHouse/ClickBench.git`
+2. cd ClickBench
+3. `bash run.sh`
+
+Note that this will output the needed result like the `result` field in <https://github.com/ClickHouse/ClickBench/blob/main/datafusion/results/f16s_v2.json>. We need to manually provide `system`, `date`, ... for now, and save a new json into `results` folder. After merged by ClickBench and new html files regenerated, it'll be shown in <https://benchmark.clickhouse.com/> .
+
+There're 43 queries to compute, each will be executed 3 times. each rows contains the execution time for these 3 quries. The overall output will be a 43 by 3 matrix.
+
+## To generate human readable results
+
+your can do
Review Comment:
```suggestion
you can do
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add a readme for clickbench intro [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #3186: add a readme for clickbench intro
URL: https://github.com/apache/arrow-datafusion/pull/3186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] waitingkuo commented on pull request #3186: add a readme for clickbench intro
Posted by GitBox <gi...@apache.org>.
waitingkuo commented on PR #3186:
URL: https://github.com/apache/arrow-datafusion/pull/3186#issuecomment-1217756958
@alamb sure i can do it. let me spend sometime checking how db-benchmark works. should i move `conbench` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3186: add a readme for clickbench intro
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #3186:
URL: https://github.com/apache/arrow-datafusion/pull/3186#discussion_r948035895
##########
clickbench/README.md:
##########
@@ -0,0 +1,52 @@
+<!---
Review Comment:
I think that we should move this file to `benchmarks/clickbench/README.md` so that all the benchmarks are in one place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add a readme for clickbench intro [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #3186:
URL: https://github.com/apache/arrow-datafusion/pull/3186#issuecomment-1830641998
Closing as this PR is over a year old. Please feel free to reopen it / rebase it if you plan to keep working on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3186: add a readme for clickbench intro
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3186:
URL: https://github.com/apache/arrow-datafusion/pull/3186#issuecomment-1217648246
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3186?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3186](https://codecov.io/gh/apache/arrow-datafusion/pull/3186?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6289054) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/85f7fc9b262c5db9d17dfef662ee58d757c6eabf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85f7fc9) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 6289054 differs from pull request most recent head 7dae4c6. Consider uploading reports for the commit 7dae4c6 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3186 +/- ##
==========================================
+ Coverage 85.86% 85.87% +0.01%
==========================================
Files 291 291
Lines 52793 52827 +34
==========================================
+ Hits 45329 45366 +37
+ Misses 7464 7461 -3
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/optimizer/src/eliminate\_filter.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL2VsaW1pbmF0ZV9maWx0ZXIucnM=) | `100.00% <0.00%> (ø)` | |
| [datafusion/core/src/physical\_plan/hash\_utils.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL2hhc2hfdXRpbHMucnM=) | `40.05% <0.00%> (ø)` | |
| [datafusion/core/tests/sql/aggregates.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9hZ2dyZWdhdGVzLnJz) | `99.36% <0.00%> (+<0.01%)` | :arrow_up: |
| [datafusion/expr/src/aggregate\_function.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9hZ2dyZWdhdGVfZnVuY3Rpb24ucnM=) | `92.33% <0.00%> (+0.02%)` | :arrow_up: |
| [datafusion/common/src/scalar.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb21tb24vc3JjL3NjYWxhci5ycw==) | `84.74% <0.00%> (+0.13%)` | :arrow_up: |
| [datafusion/physical-expr/src/aggregate/min\_max.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9hZ2dyZWdhdGUvbWluX21heC5ycw==) | `95.91% <0.00%> (+0.16%)` | :arrow_up: |
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `77.95% <0.00%> (+0.17%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3186: add a readme for clickbench intro
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #3186:
URL: https://github.com/apache/arrow-datafusion/pull/3186#discussion_r948034572
##########
clickbench/README.md:
##########
@@ -0,0 +1,52 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Clickbench Benchmark
+
+## Introduction
+
+<https://benchmark.clickhouse.com/> is a new benchmark set provided by ClickHouse. The current result for DataFusion is from Azure's `v16s_v2` VM
+
+
+## The way to reproduce
+
+1. `git clone git@github.com:ClickHouse/ClickBench.git`
+2. cd ClickBench
+3. `bash run.sh`
+
+Note that this will output the needed result like the `result` field in <https://github.com/ClickHouse/ClickBench/blob/main/datafusion/results/f16s_v2.json>. We need to manually provide `system`, `date`, ... for now, and save a new json into `results` folder. After merged by ClickBench and new html files regenerated, it'll be shown in <https://benchmark.clickhouse.com/> .
+
+There're 43 queries to compute, each will be executed 3 times. each rows contains the execution time for these 3 quries. The overall output will be a 43 by 3 matrix.
+
+## To generate human readable results
+
+your can do
+
+```bash
+bash run2.sh
+```
+
+Each query will be only exeute only once, for each query it'll print the SQL expression first then output the result. (Note that this index begins with 1, the ClickBench begins with 0)
Review Comment:
```suggestion
Each query will be executed only once, for each query it'll print the SQL expression first then output the result. (Note that this index begins with 1, the ClickBench begins with 0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3186: add a readme for clickbench intro
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3186:
URL: https://github.com/apache/arrow-datafusion/pull/3186#issuecomment-1217770534
@waitingkuo moving conbench would be great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3186: add a readme for clickbench intro
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #3186:
URL: https://github.com/apache/arrow-datafusion/pull/3186#issuecomment-1647648066
FYI here is another approach to running clickbench in the datafusion repo: https://github.com/apache/arrow-datafusion/pull/7060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org