You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/10/22 03:29:24 UTC
[GitHub] [incubator-echarts] pissang commented on a change in pull request #11445: fix-11422 关系图边增加forceIgnore属性，不参加节点位置计算
pissang commented on a change in pull request #11445: fix-11422 关系图边增加forceIgnore属性，不参加节点位置计算
URL: https://github.com/apache/incubator-echarts/pull/11445#discussion_r337318955
##########
File path: src/chart/graph/forceHelper.js
##########
@@ -95,6 +95,9 @@ export function forceLayout(nodes, edges, opts) {
var nLen = nodes.length;
for (var i = 0; i < edges.length; i++) {
var e = edges[i];
+ if (e.forceIgnore) {
Review comment:
I suggested using `ignoreFoceLayout` instead of `forceIgnore`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org