[GitHub] [yunikorn-core] wilfred-s commented on a diff in pull request #473: YUNIKORN-1437: Expose queue running app details in REST

[GitBox <gi...@apache.org>]

wilfred-s commented on code in PR #473:
URL: https://github.com/apache/yunikorn-core/pull/473#discussion_r1045380897


##########
pkg/scheduler/objects/queue.go:
##########
@@ -473,6 +473,12 @@ func (sq *Queue) GetPartitionQueueDAOInfo() dao.PartitionQueueDAOInfo {
 	} else {
 		queueInfo.Parent = sq.QueuePath[:strings.LastIndex(sq.QueuePath, configs.DOT)]
 	}
+	queueInfo.MaxRunningApps = sq.maxRunningApps
+	queueInfo.RunningApps = sq.runningApps
+	queueInfo.AllocatingAcceptedApps = make(map[string]bool)

Review Comment:
   we can use a simple slice of strings here, we do not need the booleans:
   ```
   queueInfo.AllocatingAcceptedApps = make([]string, len(sq.allocatingAcceptedApps))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org