[GitHub] [airflow] ashb commented on a diff in pull request #25312: Don't mistakenly take a lock on DagRun via ti.refresh_from_fb

[GitBox <gi...@apache.org>]

ashb commented on code in PR #25312:
URL: https://github.com/apache/airflow/pull/25312#discussion_r930161877


##########
airflow/models/taskinstance.py:
##########
@@ -848,11 +848,15 @@ def refresh_from_db(self, session: Session = NEW_SESSION, lock_for_update: bool
         """
         self.log.debug("Refreshing TaskInstance %s from DB", self)
 
-        qry = session.query(TaskInstance).filter(
-            TaskInstance.dag_id == self.dag_id,
-            TaskInstance.task_id == self.task_id,
-            TaskInstance.run_id == self.run_id,
-            TaskInstance.map_index == self.map_index,
+        qry = (
+            session.query(TaskInstance)
+            .filter(
+                TaskInstance.dag_id == self.dag_id,
+                TaskInstance.task_id == self.task_id,
+                TaskInstance.run_id == self.run_id,
+                TaskInstance.map_index == self.map_index,
+            )

Review Comment:
   I wonder if there is a way of saying to SQLA "only select this, never select anything else" (i.e. to prevent other regressions in the future



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org