Re: [PR] Core: implement commitManifestsWith executor on SnapshotUpdate [iceberg]

["huaxingao (via GitHub)" <gi...@apache.org>]

huaxingao commented on code in PR #16108:
URL: https://github.com/apache/iceberg/pull/16108#discussion_r3222677453


##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -164,6 +164,19 @@ public ThisT scanManifestsWith(ExecutorService executorService) {
     return self();
   }
 
+  @Override
+  public ThisT commitManifestsWith(ExecutorService executorService) {
+    Preconditions.checkArgument(

Review Comment:
   Sorry for the late reply. 
   I think you misunderstood my comment.  I was saying that 
   ```
   executorService instanceof java.util.concurrent.ThreadPoolExecutor
   ```
   
   
   is too strict. `scanManifestsWith` already accepts any `ExecutorService` — there's no reason `commitManifestsWith` should be stricter. If the executorService is not `ThreadPoolExecutor` but a fork join pool or stealing pool (your own example), we should still use it. Only the parallelism size hint needs to fall back when we can't read it from the executor type.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org