[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19945: [improve][broker] PIP-192 updated metrics and cleanup broker selector

["heesung-sn (via GitHub)" <gi...@apache.org>]

heesung-sn commented on code in PR #19945:
URL: https://github.com/apache/pulsar/pull/19945#discussion_r1153678589


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -1097,31 +1123,45 @@ private void doCleanup(String broker) throws ExecutionException, InterruptedExce
 
     }
 
-    private Optional<ServiceUnitStateData> getRollForwardStateData(
-            Set<String> availableBrokers, LoadManagerContext context, long nextVersionId) {
-        Optional<String> selectedBroker = brokerSelector.select(availableBrokers, null, context);
+    private Optional<String> selectBroker(String serviceUnit) {
+        var namespaceBundle = getNamespaceBundle(serviceUnit);
+        if (namespaceBundle.getNamespaceObject().equals(SYSTEM_NAMESPACE)) {

Review Comment:
   Nice catch. We shouldn't. Updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org