You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "werpu (via GitHub)" <gi...@apache.org> on 2023/04/20 18:02:32 UTC
[GitHub] [myfaces] werpu opened a new pull request, #570: MYFACES-4602: Fixes coming in from the github upstream.
werpu opened a new pull request, #570:
URL: https://github.com/apache/myfaces/pull/570
Updating also the client dependencies to the latest versions!
Code passes all needed tests, and also has been tested by Tobago!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #570: MYFACES-4602: Fixes coming in from the github upstream.
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #570:
URL: https://github.com/apache/myfaces/pull/570#issuecomment-1516749584
Guys the integration test chrome driver needs an update againm this is why the integration tests fail:
Error: IntegrationTest.testPlainHtml » Runtime Unable to instantiate Drone via org.openqa.selenium.chrome.ChromeDriver(ChromeOptions): org.openqa.selenium.SessionNotCreatedException: Could not start a new session. Response code 500. Message: session not created: This version of ChromeDriver only supports Chrome version 110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] bohmber commented on pull request #570: MYFACES-4602: Nonce handling of style tags
Posted by "bohmber (via GitHub)" <gi...@apache.org>.
bohmber commented on PR #570:
URL: https://github.com/apache/myfaces/pull/570#issuecomment-1517319672
Please change the version directly in [.github/workflows/myfaces-ci.yml](https://github.com/apache/myfaces/tree/main/.github/workflows/myfaces-ci.yml) you can specify the chromeDriverVersion in the mvn cmd line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #570: MYFACES-4602: Fixes coming in from the github upstream.
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #570:
URL: https://github.com/apache/myfaces/pull/570#issuecomment-1516737885
After this merge, the myfaces codebase and the github codebase of the ajax scripts are back in sync!
I just wanted to give the tobago guys a little bit of time to test it, just in case something comes up before merging it in again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #570: MYFACES-4602: Fixes coming in from the github upstream.
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #570:
URL: https://github.com/apache/myfaces/pull/570#issuecomment-1517252463
I will merge nevertheless, the build problems have nothing to do with my code.
The built atm simply is broken! No need to hold off with my PR since the relevant tests pass on it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu merged pull request #570: MYFACES-4602: Fixes coming in from the github upstream.
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu merged PR #570:
URL: https://github.com/apache/myfaces/pull/570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #570: MYFACES-4602: Nonce handling of style tags
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #570:
URL: https://github.com/apache/myfaces/pull/570#issuecomment-1517323829
Hi, I can have a look at it in the afternoon, I am project bound until then.
Otherwise someone else can go ahead!
But thanks for the hint!
Am Fr., 21. Apr. 2023 um 08:16 Uhr schrieb Bernd Bohmann <
***@***.***>:
> Please change the version directly in .github/workflows/myfaces-ci.yml
> <https://github.com/apache/myfaces/tree/main/.github/workflows/myfaces-ci.yml>
> you can specify the chromeDriverVersion in the mvn cmd line
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/myfaces/pull/570#issuecomment-1517319672>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAEBQ4ZJJHP36YNLYG5DSMTXCIQ3JANCNFSM6AAAAAAXF3CPRY>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org