You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/02 08:38:55 UTC
[PR] fix(i18n): localize topic table columns and row actions [rocketmq-dashboard]
yyqdbngt opened a new pull request, #2990:
URL: https://github.com/apache/rocketmq-dashboard/pull/2990
## Summary
Localize the topic table display strings (`instance/topic.tsx`) by wiring the page to the existing `topic.*` keys:
- Delete-confirm modal (`确认删除`/content/`删除`/`取消`) → `topic.confirmDelete` / new `topic.deleteContent` / `topic.delete` / `common.cancel`
- Column titles 备注/类型/状态/创建时间/修改时间/操作/Topic 名称 → `topic.remark` / `topic.type` / `topic.status` / `topic.createdAt` / `topic.updatedAt` / `topic.action` / `topic.name` (all keys already existed)
- "服务中" status tag → `topic.serving`; row buttons 详情/发送/删除 → `topic.detail` / `topic.send` / `topic.delete` (keys already existed)
- One new key: `topic.deleteContent`
## Why
The page renders its topic table and row actions entirely in Chinese in the English UI. The `topic.*` keys were defined but never wired to this table region.
## Testing
- `vitest run src/pages/instance/__tests__/TopicPage.test.tsx` → 16/16 passed
- `tsc --noEmit` → clean
- `eslint` on changed files → 0 problems
- zh render unchanged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(i18n): localize topic table columns and row actions [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2990: fix(i18n): localize topic table columns and row actions
URL: https://github.com/apache/rocketmq-dashboard/pull/2990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org