You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/25 18:54:59 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #9382:
[fix] Fixing cache key inconsistencies
john-bodley opened a new pull request #9382: [fix] Fixing cache key inconsistencies
URL: https://github.com/apache/incubator-superset/pull/9382
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Whilst testing some caching logic I realized that for some slices the cache key was different between the `/superset/warm_up_cache/?slice_id=<id>` and `/superset/slice/<id>/` endpoints.
The reasons being is that the `time_grain_sqla` (SQL) and `grainularity` (Druid NoSQL) fields are now optional for a number of visualization types and the frontend removes any erroneous fields which are not defined by the chart controls resulting in inconsistent form data.
This regression was introduced by me in via the following PRs:
- https://github.com/apache/incubator-superset/pull/8674
- https://github.com/apache/incubator-superset/pull/8764
- https://github.com/apache/incubator-superset/pull/8800
- https://github.com/apache/incubator-superset/pull/8825
This PR:
1. Adds a migration to clean up erroneous `time_grain_sqla` (SQL) and `grainularity` (Druid NoSQL) fields in saved slice parameters.
2. Encodes `time_grain_sqla` form-data as `None` as opposed to `""` for consistency.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
Tested locally and confirmed that the cache keys were identical.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [x] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @etr2460 @graceguo-supercat @ktmud @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9382: [fix]
Removing erroneous slice parameters resulting in cache key inconsistencies
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9382: [fix] Removing erroneous slice parameters resulting in cache key inconsistencies
URL: https://github.com/apache/incubator-superset/pull/9382#issuecomment-605503152
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9382?src=pr&el=h1) Report
> Merging [#9382](https://codecov.io/gh/apache/incubator-superset/pull/9382?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/499f9c8fca3ea01b7f7eeb977531669518c5dc4b&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9382?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9382 +/- ##
=======================================
Coverage 59.01% 59.01%
=======================================
Files 378 378
Lines 12162 12162
Branches 3004 3004
=======================================
Hits 7177 7177
Misses 4805 4805
Partials 180 180
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9382?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9382?src=pr&el=footer). Last update [499f9c8...a96db61](https://codecov.io/gh/apache/incubator-superset/pull/9382?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #9382: [fix]
Removing erroneous slice parameters resulting in cache key inconsistencies
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9382: [fix] Removing erroneous slice parameters resulting in cache key inconsistencies
URL: https://github.com/apache/incubator-superset/pull/9382
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org