You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/07/08 19:55:44 UTC

Review Request 36320: Enable debugging tools on the scheduler in vagrant.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36320/
-----------------------------------------------------------

Review request for Aurora and Zameer Manji.


Repository: aurora


Description
-------

This enables remote debugging on the JVM, allowing you to attach by default when developing.  This also enables the H2 console, which is extremely useful for debugging DB state.


Diffs
-----

  examples/vagrant/upstart/aurora-scheduler.conf 1c2390f0248e91e65a548e67f6af1be8d2526b0a 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 82d479e142afe798cd84135b981075035d9ca6dc 

Diff: https://reviews.apache.org/r/36320/diff/


Testing
-------

Ran in vagrant.


Thanks,

Bill Farner


Re: Review Request 36320: Enable debugging tools on the scheduler in vagrant.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36320/#review90938
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On July 8, 2015, 10:57 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36320/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 10:57 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This enables remote debugging on the JVM, allowing you to attach by default when developing.  This also enables the H2 console, which is extremely useful for debugging DB state.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler.conf 1c2390f0248e91e65a548e67f6af1be8d2526b0a 
> 
> Diff: https://reviews.apache.org/r/36320/diff/
> 
> 
> Testing
> -------
> 
> Ran in vagrant.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 36320: Enable debugging tools on the scheduler in vagrant.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36320/#review90951
-----------------------------------------------------------

Ship it!


Master (62a432a) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 8, 2015, 5:57 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36320/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 5:57 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This enables remote debugging on the JVM, allowing you to attach by default when developing.  This also enables the H2 console, which is extremely useful for debugging DB state.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler.conf 1c2390f0248e91e65a548e67f6af1be8d2526b0a 
> 
> Diff: https://reviews.apache.org/r/36320/diff/
> 
> 
> Testing
> -------
> 
> Ran in vagrant.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 36320: Enable debugging tools on the scheduler in vagrant.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36320/
-----------------------------------------------------------

(Updated July 8, 2015, 5:57 p.m.)


Review request for Aurora and Zameer Manji.


Repository: aurora


Description
-------

This enables remote debugging on the JVM, allowing you to attach by default when developing.  This also enables the H2 console, which is extremely useful for debugging DB state.


Diffs (updated)
-----

  examples/vagrant/upstart/aurora-scheduler.conf 1c2390f0248e91e65a548e67f6af1be8d2526b0a 

Diff: https://reviews.apache.org/r/36320/diff/


Testing
-------

Ran in vagrant.


Thanks,

Bill Farner