[GitHub] [superset] kasiazjc commented on pull request #23590: feat: Enables ECharts legend selector

["kasiazjc (via GitHub)" <gi...@apache.org>]

kasiazjc commented on PR #23590:
URL: https://github.com/apache/superset/pull/23590#issuecomment-1498887521

   > Amazing!! I wonder if "Inv" is clear enough from the label? Curious what @kasiazjc thinks
   
   @michael-s-molina this is very cool! 
   
   I have a few thoughts - 
   - If all things are selected, should "all" button be active? then, if you would select "inv", inv becomes active instead and from there you can: 
       - deselect inv at it comes back to "all" 
       - choose other legend thing and inv becomes deselected 🤔 
   
   I think this would be a good indicator to show in which state you currently are in thoughts @yousoph @michael-s-molina ?
   - on "inv" (or "invsel"), for me it is not intuitive at all, but I know it's used :D I think we should add a tooltip to "inv", maybe 
   > Selecting 'inv' will invert the legend selection.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org