You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Abhishek Kumar <la...@gmail.com> on 2017/01/23 11:21:57 UTC
Review Request 55837: Hive View 2.0: Incorrect behaviour on select of
database
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55837/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-19671
https://issues.apache.org/jira/browse/AMBARI-19671
Repository: ambari
Description
-------
On selecting a database from right panel, display does not change. Ideally followings should happen:
1. Move "checked" icon to selected database
2. Hide tables related to unselected database and show tables for the selected one.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 950e4f3
Diff: https://reviews.apache.org/r/55837/diff/
Testing
-------
Thanks,
Abhishek Kumar
Re: Review Request 55837: Hive View 2.0: Incorrect behaviour on
select of database
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55837/#review162906
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Jan. 23, 2017, 11:37 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55837/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 11:37 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19671
> https://issues.apache.org/jira/browse/AMBARI-19671
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On selecting a database from right panel, display does not change. Ideally followings should happen:
> 1. Move "checked" icon to selected database
> 2. Hide tables related to unselected database and show tables for the selected one.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 950e4f3
>
> Diff: https://reviews.apache.org/r/55837/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 55837: Hive View 2.0: Incorrect behaviour on
select of database
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55837/#review162776
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Jan. 23, 2017, 11:37 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55837/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 11:37 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19671
> https://issues.apache.org/jira/browse/AMBARI-19671
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On selecting a database from right panel, display does not change. Ideally followings should happen:
> 1. Move "checked" icon to selected database
> 2. Hide tables related to unselected database and show tables for the selected one.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 950e4f3
>
> Diff: https://reviews.apache.org/r/55837/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 55837: Hive View 2.0: Incorrect behaviour on
select of database
Posted by Abhishek Kumar <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55837/
-----------------------------------------------------------
(Updated Jan. 23, 2017, 11:37 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-19671
https://issues.apache.org/jira/browse/AMBARI-19671
Repository: ambari
Description
-------
On selecting a database from right panel, display does not change. Ideally followings should happen:
1. Move "checked" icon to selected database
2. Hide tables related to unselected database and show tables for the selected one.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 950e4f3
Diff: https://reviews.apache.org/r/55837/diff/
Testing (updated)
-------
Manually tested
Thanks,
Abhishek Kumar