You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by Alexander Saydakov <sa...@yahooinc.com.INVALID> on 2023/11/08 04:37:54 UTC
[VOTE] Release Apache DataSketches-cpp 5.0.0-rc1
Hello Apache DataSketches PMC and Community,
This is a call for vote to release Apache DataSketches-cpp candidate
version 5.0.0-rc1
This is a major reseate due to separation of Python part of the library
into its own repository datasketches-python, which can potentially be
API-breaking for somebody.
We also took this opportunity to do some other possibly API-breaking
cleanup.
Changes since datasketches-cpp 4.1.0 release (3 May 2023):
- moved all Python-related code to new datasketches-python repository
- finished moving public constants to separate namespaces
- removed deprecated methods (such as get_quantiles())
- generalized array_of_doubles sketch as array_tuple_sketch
- implemented new EB-PPS sketch (exact PPS sampling with bounded sample
size)
- fixed slowness in Theta intersection
- fixed incompatibility of serialized empty frequent items sketches
with Java
Source repository:
- https://github.com/apache/datasketches-cpp
Git Tag for this release:
- https://github.com/apache/datasketches-cpp/releases/tag/5.0.0-rc1 on
branch 5.0.x
Git HashId for this release is: b39e41be2b743acb10f0b8b0bb491524fb17c77a
The Release Candidate Zip Repository:
- https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.0.0-rc1/
The public signing key can be found in the KEYS file:
- https://dist.apache.org/repos/dist/dev/datasketches/KEYS
<https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
The artifacts have been signed with key:
68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
alsay@apache.org>
Build & Test Guide (C++):
- https://github.com/apache/datasketches-cpp/blob/5.0.0-rc1/README.md
The vote will be performed as follows:
- This letter will be published on dev@ and remain open for at least 72
hours (excluding weekends and holidays), AND until at least 3 (+1)
PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the
community can vote.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thank you,
Alexander Saydakov
alsay@apache.org
Re: [E] Re: [VOTE] Release Apache DataSketches-cpp 5.0.0-rc1
Posted by Charlie Dickens <ch...@yahooinc.com.INVALID>.
+1
I checked:
- license and notice;
- version.cfg.in;
- compiled and ran unit tests in mac m1 pro ventura 13.5.2
On Thu, 9 Nov 2023 at 03:36, Jon Malkin <jo...@gmail.com> wrote:
> +1 (binding)
>
> I checked:
> * Checksum and signature
> * LICENSE and NOTICE present and current
> * version.cfg.in
> <https://urldefense.com/v3/__http://version.cfg.in__;!!Op6eflyXZCqGR5I!DjrRQSsCoBH1u7aIRj0n8B03Qp9vIpHxzGyOFSOUcjYS8L9rslZ9Zim6hathatPStfCrhXZrWKkvQhFzB_Z_5a5sGnq8$>
> correctly set to 5.0.0
> * Compiled and ran unit tests on Linux/x86_64
> * New EBPPS sketch and version install correctly
>
> Configuring cmake took a long time for some reason but it did work. I
> didn't have verbose logging so I'm not sure what took so long.
>
> We did include sketch images from java in test directories. I don't think
> they're needed anymore with the new cross-repo tests, but they're in test
> directories so I don't think it's problematic.
>
> jon
>
> On Tue, Nov 7, 2023 at 8:39 PM Alexander Saydakov
> <sa...@yahooinc.com.invalid> wrote:
>
>> Hello Apache DataSketches PMC and Community,
>>
>>
>> This is a call for vote to release Apache DataSketches-cpp candidate
>> version 5.0.0-rc1
>>
>>
>> This is a major reseate due to separation of Python part of the library
>> into its own repository datasketches-python, which can potentially be
>> API-breaking for somebody.
>>
>> We also took this opportunity to do some other possibly API-breaking
>> cleanup.
>>
>>
>> Changes since datasketches-cpp 4.1.0 release (3 May 2023):
>>
>> - moved all Python-related code to new datasketches-python repository
>>
>> - finished moving public constants to separate namespaces
>>
>> - removed deprecated methods (such as get_quantiles())
>>
>> - generalized array_of_doubles sketch as array_tuple_sketch
>>
>> - implemented new EB-PPS sketch (exact PPS sampling with bounded
>> sample size)
>>
>> - fixed slowness in Theta intersection
>>
>> - fixed incompatibility of serialized empty frequent items sketches
>> with Java
>>
>>
>> Source repository:
>>
>> - https://github.com/apache/datasketches-cpp
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!DjrRQSsCoBH1u7aIRj0n8B03Qp9vIpHxzGyOFSOUcjYS8L9rslZ9Zim6hathatPStfCrhXZrWKkvQhFzB_Z_5Xf1nt3r$>
>>
>>
>> Git Tag for this release:
>>
>> - https://github.com/apache/datasketches-cpp/releases/tag/5.0.0-rc1
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/5.0.0-rc1__;!!Op6eflyXZCqGR5I!DjrRQSsCoBH1u7aIRj0n8B03Qp9vIpHxzGyOFSOUcjYS8L9rslZ9Zim6hathatPStfCrhXZrWKkvQhFzB_Z_5XZ9wsR5$> on
>> branch 5.0.x
>>
>>
>> Git HashId for this release is: b39e41be2b743acb10f0b8b0bb491524fb17c77a
>>
>>
>> The Release Candidate Zip Repository:
>>
>> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.0.0-rc1/
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.0.0-rc1/__;!!Op6eflyXZCqGR5I!DjrRQSsCoBH1u7aIRj0n8B03Qp9vIpHxzGyOFSOUcjYS8L9rslZ9Zim6hathatPStfCrhXZrWKkvQhFzB_Z_5UN-sEbY$>
>>
>>
>> The public signing key can be found in the KEYS file:
>>
>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
>>
>>
>>
>> The artifacts have been signed with key:
>>
>> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
>> alsay@apache.org>
>>
>>
>> Build & Test Guide (C++):
>>
>> - https://github.com/apache/datasketches-cpp/blob/5.0.0-rc1/README.md
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/5.0.0-rc1/README.md__;!!Op6eflyXZCqGR5I!DjrRQSsCoBH1u7aIRj0n8B03Qp9vIpHxzGyOFSOUcjYS8L9rslZ9Zim6hathatPStfCrhXZrWKkvQhFzB_Z_5Xj90ZGH$>
>>
>>
>> The vote will be performed as follows:
>>
>> - This letter will be published on dev@ and remain open for at least
>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1)
>> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the
>> community can vote.
>>
>>
>> Please vote accordingly:
>>
>>
>> [ ] +1 approve
>>
>> [ ] +0 no opinion
>>
>> [ ] -1 disapprove with the reason
>>
>>
>> Thank you,
>>
>> Alexander Saydakov
>>
>> alsay@apache.org
>>
>>
Re: [VOTE] Release Apache DataSketches-cpp 5.0.0-rc1
Posted by Jon Malkin <jo...@gmail.com>.
+1 (binding)
I checked:
* Checksum and signature
* LICENSE and NOTICE present and current
* version.cfg.in correctly set to 5.0.0
* Compiled and ran unit tests on Linux/x86_64
* New EBPPS sketch and version install correctly
Configuring cmake took a long time for some reason but it did work. I
didn't have verbose logging so I'm not sure what took so long.
We did include sketch images from java in test directories. I don't think
they're needed anymore with the new cross-repo tests, but they're in test
directories so I don't think it's problematic.
jon
On Tue, Nov 7, 2023 at 8:39 PM Alexander Saydakov
<sa...@yahooinc.com.invalid> wrote:
> Hello Apache DataSketches PMC and Community,
>
>
> This is a call for vote to release Apache DataSketches-cpp candidate
> version 5.0.0-rc1
>
>
> This is a major reseate due to separation of Python part of the library
> into its own repository datasketches-python, which can potentially be
> API-breaking for somebody.
>
> We also took this opportunity to do some other possibly API-breaking
> cleanup.
>
>
> Changes since datasketches-cpp 4.1.0 release (3 May 2023):
>
> - moved all Python-related code to new datasketches-python repository
>
> - finished moving public constants to separate namespaces
>
> - removed deprecated methods (such as get_quantiles())
>
> - generalized array_of_doubles sketch as array_tuple_sketch
>
> - implemented new EB-PPS sketch (exact PPS sampling with bounded
> sample size)
>
> - fixed slowness in Theta intersection
>
> - fixed incompatibility of serialized empty frequent items sketches
> with Java
>
>
> Source repository:
>
> - https://github.com/apache/datasketches-cpp
>
>
> Git Tag for this release:
>
> - https://github.com/apache/datasketches-cpp/releases/tag/5.0.0-rc1 on
> branch 5.0.x
>
>
> Git HashId for this release is: b39e41be2b743acb10f0b8b0bb491524fb17c77a
>
>
> The Release Candidate Zip Repository:
>
> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.0.0-rc1/
>
>
> The public signing key can be found in the KEYS file:
>
> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
>
>
>
> The artifacts have been signed with key:
>
> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> alsay@apache.org>
>
>
> Build & Test Guide (C++):
>
> - https://github.com/apache/datasketches-cpp/blob/5.0.0-rc1/README.md
>
>
> The vote will be performed as follows:
>
> - This letter will be published on dev@ and remain open for at least
> 72 hours (excluding weekends and holidays), AND until at least 3 (+1)
> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the
> community can vote.
>
>
> Please vote accordingly:
>
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
> Thank you,
>
> Alexander Saydakov
>
> alsay@apache.org
>
>
Re: [E] Re: [VOTE] Release Apache DataSketches-cpp 5.0.0-rc1
Posted by Alexander Saydakov <sa...@yahooinc.com.INVALID>.
I believe enough time has passed and we have 3 binding votes in support of
this candidate. Please consider this vote closed.
Thanks to everyone who participated.
On Mon, Nov 13, 2023 at 10:35 AM Lee Rhodes <le...@gmail.com> wrote:
> +1
> I checked
> - LICENSE and NOTICE present and current
> - version.cfg.in
> <https://urldefense.com/v3/__http://version.cfg.in/__;!!Op6eflyXZCqGR5I!F-Ma4LsKNdRZGy1x-7c0P8fDlU2hBxOdvcq8Cd5gmMq4YbBFMK2XzUXBxmpqF6og_9hNm2hU69DBL58$> correctly
> set to 5.0.0
> - Compiled and ran unit tests on OSX Ventura 13.5.2, Apple M1 Pro
> - Checked both asc and sha512 signatures.
> - The Build and Test Guide was good and it worked perfectly.
>
> On Tue, Nov 7, 2023 at 8:39 PM Alexander Saydakov
> <sa...@yahooinc.com.invalid> wrote:
>
>> Hello Apache DataSketches PMC and Community,
>>
>>
>> This is a call for vote to release Apache DataSketches-cpp candidate
>> version 5.0.0-rc1
>>
>>
>> This is a major reseate due to separation of Python part of the library
>> into its own repository datasketches-python, which can potentially be
>> API-breaking for somebody.
>>
>> We also took this opportunity to do some other possibly API-breaking
>> cleanup.
>>
>>
>> Changes since datasketches-cpp 4.1.0 release (3 May 2023):
>>
>> - moved all Python-related code to new datasketches-python repository
>>
>> - finished moving public constants to separate namespaces
>>
>> - removed deprecated methods (such as get_quantiles())
>>
>> - generalized array_of_doubles sketch as array_tuple_sketch
>>
>> - implemented new EB-PPS sketch (exact PPS sampling with bounded
>> sample size)
>>
>> - fixed slowness in Theta intersection
>>
>> - fixed incompatibility of serialized empty frequent items sketches
>> with Java
>>
>>
>> Source repository:
>>
>> - https://github.com/apache/datasketches-cpp
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!F-Ma4LsKNdRZGy1x-7c0P8fDlU2hBxOdvcq8Cd5gmMq4YbBFMK2XzUXBxmpqF6og_9hNm2hUq6xgcjc$>
>>
>>
>> Git Tag for this release:
>>
>> - https://github.com/apache/datasketches-cpp/releases/tag/5.0.0-rc1
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/5.0.0-rc1__;!!Op6eflyXZCqGR5I!F-Ma4LsKNdRZGy1x-7c0P8fDlU2hBxOdvcq8Cd5gmMq4YbBFMK2XzUXBxmpqF6og_9hNm2hUzQF_wqw$> on
>> branch 5.0.x
>>
>>
>> Git HashId for this release is: b39e41be2b743acb10f0b8b0bb491524fb17c77a
>>
>>
>> The Release Candidate Zip Repository:
>>
>> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.0.0-rc1/
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.0.0-rc1/__;!!Op6eflyXZCqGR5I!F-Ma4LsKNdRZGy1x-7c0P8fDlU2hBxOdvcq8Cd5gmMq4YbBFMK2XzUXBxmpqF6og_9hNm2hUy2n7GTQ$>
>>
>>
>> The public signing key can be found in the KEYS file:
>>
>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
>>
>>
>>
>> The artifacts have been signed with key:
>>
>> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
>> alsay@apache.org>
>>
>>
>> Build & Test Guide (C++):
>>
>> - https://github.com/apache/datasketches-cpp/blob/5.0.0-rc1/README.md
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/5.0.0-rc1/README.md__;!!Op6eflyXZCqGR5I!F-Ma4LsKNdRZGy1x-7c0P8fDlU2hBxOdvcq8Cd5gmMq4YbBFMK2XzUXBxmpqF6og_9hNm2hUh12jUUg$>
>>
>>
>> The vote will be performed as follows:
>>
>> - This letter will be published on dev@ and remain open for at least
>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1)
>> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the
>> community can vote.
>>
>>
>> Please vote accordingly:
>>
>>
>> [ ] +1 approve
>>
>> [ ] +0 no opinion
>>
>> [ ] -1 disapprove with the reason
>>
>>
>> Thank you,
>>
>> Alexander Saydakov
>>
>> alsay@apache.org
>>
>>
Re: [VOTE] Release Apache DataSketches-cpp 5.0.0-rc1
Posted by Lee Rhodes <le...@gmail.com>.
+1
I checked
- LICENSE and NOTICE present and current
- version.cfg.in correctly set to 5.0.0
- Compiled and ran unit tests on OSX Ventura 13.5.2, Apple M1 Pro
- Checked both asc and sha512 signatures.
- The Build and Test Guide was good and it worked perfectly.
On Tue, Nov 7, 2023 at 8:39 PM Alexander Saydakov
<sa...@yahooinc.com.invalid> wrote:
> Hello Apache DataSketches PMC and Community,
>
>
> This is a call for vote to release Apache DataSketches-cpp candidate
> version 5.0.0-rc1
>
>
> This is a major reseate due to separation of Python part of the library
> into its own repository datasketches-python, which can potentially be
> API-breaking for somebody.
>
> We also took this opportunity to do some other possibly API-breaking
> cleanup.
>
>
> Changes since datasketches-cpp 4.1.0 release (3 May 2023):
>
> - moved all Python-related code to new datasketches-python repository
>
> - finished moving public constants to separate namespaces
>
> - removed deprecated methods (such as get_quantiles())
>
> - generalized array_of_doubles sketch as array_tuple_sketch
>
> - implemented new EB-PPS sketch (exact PPS sampling with bounded
> sample size)
>
> - fixed slowness in Theta intersection
>
> - fixed incompatibility of serialized empty frequent items sketches
> with Java
>
>
> Source repository:
>
> - https://github.com/apache/datasketches-cpp
>
>
> Git Tag for this release:
>
> - https://github.com/apache/datasketches-cpp/releases/tag/5.0.0-rc1 on
> branch 5.0.x
>
>
> Git HashId for this release is: b39e41be2b743acb10f0b8b0bb491524fb17c77a
>
>
> The Release Candidate Zip Repository:
>
> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.0.0-rc1/
>
>
> The public signing key can be found in the KEYS file:
>
> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
>
>
>
> The artifacts have been signed with key:
>
> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> alsay@apache.org>
>
>
> Build & Test Guide (C++):
>
> - https://github.com/apache/datasketches-cpp/blob/5.0.0-rc1/README.md
>
>
> The vote will be performed as follows:
>
> - This letter will be published on dev@ and remain open for at least
> 72 hours (excluding weekends and holidays), AND until at least 3 (+1)
> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the
> community can vote.
>
>
> Please vote accordingly:
>
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
> Thank you,
>
> Alexander Saydakov
>
> alsay@apache.org
>
>