[GitHub] [spark] dchvn commented on a change in pull request #35067: [SPARK-37423][PYTHON] Inline type hints for fpm.py in python/pyspark/mllib

[GitBox <gi...@apache.org>]

dchvn commented on a change in pull request #35067:
URL: https://github.com/apache/spark/pull/35067#discussion_r834896041



##########
File path: python/pyspark/mllib/fpm.py
##########
@@ -17,17 +17,20 @@
 
 import sys
 
-from collections import namedtuple
+from typing import Any, Generic, List, NamedTuple, TypeVar
 
-from pyspark import since
+from pyspark import since, SparkContext
 from pyspark.mllib.common import JavaModelWrapper, callMLlibFunc
 from pyspark.mllib.util import JavaSaveable, JavaLoader, inherit_doc
+from pyspark.rdd import RDD
 
-__all__ = ["FPGrowth", "FPGrowthModel", "PrefixSpan", "PrefixSpanModel"]
+_all__ = ["FPGrowth", "FPGrowthModel", "PrefixSpan", "PrefixSpanModel"]

Review comment:
       Oh, my mistake, updated! Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org