[GitHub] [cordova-ios] bpresles edited a comment on issue #663: Fix #661: Removed all UIWebView code.

[GitBox <gi...@apache.org>]

bpresles edited a comment on issue #663: Fix #661: Removed all UIWebView code.
URL: https://github.com/apache/cordova-ios/pull/663#issuecomment-528002536
 
 
   > I don't see why #662 should not work if the preference is set correctly. All `UIWebview`-related code is encapsulated in preprocessor conditions.
   > Maybe you have some other plugin in your Cordova project that still contains traces to `UIWebView`?
   
   I added this line on the iOS platform section in my config.xml:
   
   `<preference name=“WKWebViewOnly” value=“true” />`
   
   Then I removed the iOS platform all together and added it back, and made sure on XCode that the `WK_WEB_VIEW_ONLY` setting was added  in the user defined build settings and set to `1` which was the case.
   
   Then I cleaned the build folder and build and run the app which was working just fine using `WKWebview` from `cordova-plugin-wkwebview-engine`.
   
   So I make an Archive and submitted the app to AppStore Connect. And I still got the warning. I tried to completely remove the `node_modules` folder as well as the `plugins` folder to make sure that they geet fetched again, and remove iOS platform than readded, but it was no better (the app worked fine but AppStore Connect still reported the UIWebView deprecation warning).
   
   Then I worked on removing all reference of `UIWebView` in `cordova-ios` and removed the embedded CDVUIWebViewEngine, at first still using the `cordova-plugin-wkwebview-engine` plug-in without embedding it, and it was only then I could send an archive that didn’t trigger the deprecation warning (so without changing anything in my installed plugins). And then I worked on embedding the `cordova-ios` and removed the embedded CDVUIWebViewEngine, at first still using the `cordova-plugin-wkwebview-engine` directly in `cordova-ios` as default engine.
   
   Also I don’t think that making the wkwebview only just an optional compile time preference isn’t a good idea. Because as Apple will not just deprecate the UIWebView APIs but reject all apps using them in the future, it’s not very useful to keep this old UIWebView based engine as default.
   If anyone want to still use UIWebView they can simply use previous versions of `cordova-ios` that are using it as default engine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org