Re: [PR] refactor: Removes the legacy Sunburst chart [superset]

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on PR #26350:
URL: https://github.com/apache/superset/pull/26350#issuecomment-1879481430

   @michael-s-molina I was wondering if the title of the PR "refactor: Removes the legacy Sunburst chart" should be updated? A non-informed reader may recoil thinking that you're simply removing the legacy chart, whereas in actuality you're actually migrating all their legacy charts to the ECharts equivalent and annexing all the legacy code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org