You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xtable.apache.org by "vinishjail97 (via GitHub)" <gi...@apache.org> on 2025/04/07 19:00:54 UTC
[PR] [678] Introduce maturity-level in xtable-api and Refactor SyncStatusCode into separate class [incubator-xtable]
vinishjail97 opened a new pull request, #685:
URL: https://github.com/apache/incubator-xtable/pull/685
## *Important Read*
- *Please ensure the GitHub issue is mentioned at the beginning of the PR*
## What is the purpose of the pull request
Refactoring classes for SyncStatusCode and ErrorDetails into separate classes for the PolicySync interfaces and methods.
https://github.com/apache/incubator-xtable/pull/644/files
## Brief change log
*(for example:)*
- *Refactor classes for SyncStatusCode and ErrorDetails*
- *Introduce maturity level for xtable-api module*
## Verify this pull request
This pull request is already covered by existing tests, such as *(please describe tests)*.
*(example:)*
- *xtable-api/src/test/java/org/apache/xtable/spi/sync/TestCatalogSync.java*
- *xtable-api/src/test/java/org/apache/xtable/spi/sync/TestTableFormatSync.java*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [678] Introduce maturity-level in xtable-api and Refactor SyncStatusCode into separate class [incubator-xtable]
Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on code in PR #685:
URL: https://github.com/apache/incubator-xtable/pull/685#discussion_r2031936600
##########
xtable-api/src/main/java/org/apache/xtable/MaturityLevel.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.xtable;
+
+public enum MaturityLevel {
+ /**
+ * New APIs start out in this state. Although enough thought will be given to avoid breaking
+ * changes to the API in the future, sometimes it might need to change based on feedback.
+ */
+ EVOLVING,
Review Comment:
They only have an Evolving one from what I could find, having stable and deprecated in the same class may be better.
https://github.com/delta-io/delta/blob/master/kernel/kernel-api/src/main/java/io/delta/kernel/annotation/Evolving.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [678] Introduce maturity-level in xtable-api and Refactor SyncStatusCode into separate class [incubator-xtable]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #685:
URL: https://github.com/apache/incubator-xtable/pull/685#discussion_r2031939596
##########
xtable-api/src/main/java/org/apache/xtable/MaturityLevel.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.xtable;
+
+public enum MaturityLevel {
+ /**
+ * New APIs start out in this state. Although enough thought will be given to avoid breaking
+ * changes to the API in the future, sometimes it might need to change based on feedback.
+ */
+ EVOLVING,
Review Comment:
Java already has deprecated and you can still add another class for `Stable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [678] Introduce maturity-level in xtable-api and Refactor SyncStatusCode into separate class [incubator-xtable]
Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 merged PR #685:
URL: https://github.com/apache/incubator-xtable/pull/685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [678] Introduce maturity-level in xtable-api and Refactor SyncStatusCode into separate class [incubator-xtable]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #685:
URL: https://github.com/apache/incubator-xtable/pull/685#discussion_r2031899072
##########
xtable-api/src/main/java/org/apache/xtable/MaturityLevel.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.xtable;
+
+public enum MaturityLevel {
+ /**
+ * New APIs start out in this state. Although enough thought will be given to avoid breaking
+ * changes to the API in the future, sometimes it might need to change based on feedback.
+ */
+ EVOLVING,
Review Comment:
Another option is to make these annotations themselves similar to what Delta does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [678] Introduce maturity-level in xtable-api and Refactor SyncStatusCode into separate class [incubator-xtable]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #685:
URL: https://github.com/apache/incubator-xtable/pull/685#discussion_r2031902007
##########
xtable-api/src/main/java/org/apache/xtable/MaturityLevel.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.xtable;
Review Comment:
Can you put these under an `annotations` sub-package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org