You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "wutongyuonce (via GitHub)" <gi...@apache.org> on 2026/09/16 13:16:30 UTC
[I] fix(runtime-host): isolate staged external Session recovery failures [maka]
wutongyuonce opened a new issue, #5401:
URL: https://github.com/apache/maka/issues/5401
## Problem
External Session startup recovery can prevent the entire Runtime Host from reaching `ready` when one staged import fails twice.
`ExternalSessionCoordinator.recover()` processes every Session with `transcriptLedgerVersion === 0` by awaiting `#prepareStagedSession()`. If Ledger preparation fails, `#prepareStagedSession()` tries to discard the staged Session. When that discard also fails, the second error escapes the loop and aborts Runtime Host domain startup. One damaged staged import can therefore make every unrelated Session and Host operation unavailable.
This was identified while reviewing #5308: https://github.com/apache/maka/pull/5308#pullrequestreview-5222054887
## Invariant and authority
`ExternalSessionCoordinator` owns staged-import recovery. Failure to recover or discard one staged Session must not prevent recovery of other staged Sessions or prevent the Runtime Host from becoming ready.
The failure must remain observable; isolation must not silently publish the staged Session or count it as an imported copy.
## Acceptance criteria
- Recovery isolates failures per staged Session.
- A prepare failure followed by a discard failure does not abort recovery of later staged Sessions.
- The Runtime Host can still complete startup after the isolated failure.
- The failed Session remains unpublished (`transcriptLedgerVersion === 0`) unless it was successfully prepared, and it is not included in imported-copy counts.
- An owner-level `ExternalSessionCoordinator` regression covers the double-failure case and proves that a later staged Session is still recovered.
- No client recovery state or protocol field is added; the fix stays at the coordinator recovery authority.
## Relevant code
- `packages/runtime-host/src/server/external-session-coordinator.ts`
- `packages/runtime-host/src/__tests__/external-session-coordinator.test.ts`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] fix(runtime-host): isolate staged external Session recovery failures [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed issue #5401: fix(runtime-host): isolate staged external Session recovery failures
URL: https://github.com/apache/maka/issues/5401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] fix(runtime-host): isolate staged external Session recovery failures [maka]
Posted by "wutongyuonce (via GitHub)" <gi...@apache.org>.
wutongyuonce commented on issue #5401:
URL: https://github.com/apache/maka/issues/5401#issuecomment-5698084358
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org