[GitHub] [gobblin] jack-moseley commented on a change in pull request #3441: [GOBBLIN-1588] Send failure events for write failures when watermark is advanced in MCE writer

[GitBox <gi...@apache.org>]

jack-moseley commented on a change in pull request #3441:
URL: https://github.com/apache/gobblin/pull/3441#discussion_r764307752



##########
File path: gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/GobblinMCEWriter.java
##########
@@ -420,4 +434,22 @@ public static State setHiveRegProperties(State state, GobblinMetadataChangeEvent
     }
     return tmpState;
   }
+
+  /**
+   * Submit event indicating that a specific set of GMCEs have been skipped, so there is a gap in the registration
+   */
+  private void submitFailureEvent(GobblinMetadataException exception) {
+    log.warn(String.format("Sending GTE to indicate table flush failure for %s", exception.tableName));
+
+    GobblinEventBuilder gobblinTrackingEvent = new GobblinEventBuilder(IcebergMCEMetadataKeys.ICEBERG_COMMIT_EVENT_NAME);

Review comment:
       Whoops yeah I meant to change that but forgot




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org