You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/24 08:22:19 UTC
[GitHub] [flink] wuchong commented on a change in pull request #9909:
[FLINK-14381][table] Partition field names should be got from CatalogTable
instead of source/sink
wuchong commented on a change in pull request #9909: [FLINK-14381][table] Partition field names should be got from CatalogTable instead of source/sink
URL: https://github.com/apache/flink/pull/9909#discussion_r338437582
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/PartitionableTableSource.java
##########
@@ -43,17 +42,6 @@
*/
List<Map<String, String>> getPartitions();
Review comment:
Should we also remove this method? Because all the partition specs should also go through `Catalog`? i.e. `Catalog#listPartitions`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services