You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/11/09 11:17:00 UTC

[jira] [Commented] (DISPATCH-1814) Apply autofixes to resolve some flake8 code formatting issues

    [ https://issues.apache.org/jira/browse/DISPATCH-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228521#comment-17228521 ] 

ASF GitHub Bot commented on DISPATCH-1814:
------------------------------------------

jiridanek commented on pull request #895:
URL: https://github.com/apache/qpid-dispatch/pull/895#issuecomment-723947897


   As per discussion on users@qpid, this is to contain all autofixes in single commit, and it is to be merged soon after a completed release.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Apply autofixes to resolve some flake8 code formatting issues
> -------------------------------------------------------------
>
>                 Key: DISPATCH-1814
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1814
>             Project: Qpid Dispatch
>          Issue Type: Task
>    Affects Versions: 1.14.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Trivial
>
> The general strategy for dealing with these in a scalable manner could be as follows
> Identify warning we want to resolve, e.g. E701 multiple statements on a single line.
> Remove E701 from flake8 ignore list in {{tests/tox.ini.in}}.
> Run the autofixer
> {code}
> pip install autoflake8
> for f in `find -name "*.py"`; do autopep8 --in-place --select=E701 $f; done
> for f in `find tests -name "*.py.in"`; do autopep8 --in-place --select=E701 $f; done
> autopep8 --in-place --select=E701 tools/*.in
> {code}
> Wait about two minutes.
> Review the diffs produced.
> Submit a change request.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org