You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "Saifulhuq01 (via GitHub)" <gi...@apache.org> on 2026/02/03 07:56:44 UTC
[PR] FINERACT-2464: Refactor LoanScheduleAssembler logic extraction [fineract]
Saifulhuq01 opened a new pull request, #5438:
URL: https://github.com/apache/fineract/pull/5438
## Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
- [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2464: Refactor LoanScheduleAssembler logic extraction [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #5438:
URL: https://github.com/apache/fineract/pull/5438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2464: Refactor LoanScheduleAssembler logic extraction [fineract]
Posted by "Saifulhuq01 (via GitHub)" <gi...@apache.org>.
Saifulhuq01 commented on code in PR #5438:
URL: https://github.com/apache/fineract/pull/5438#discussion_r2792699344
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleAssembler.java:
##########
@@ -314,8 +314,10 @@ private LoanApplicationTerms assembleLoanApplicationTermsFrom(final JsonElement
calculatedRepaymentsStartingFromDate = deriveFirstRepaymentDate(loanType, repaymentEvery, expectedDisbursementDate,
repaymentPeriodFrequencyType, loanProduct.getMinimumDaysBetweenDisbursalAndFirstRepayment(), calendar, submittedOnDate,
repaymentStartDateType);
- // If calculated repayment start date does not match due to minimum days between disbursal and first
- // repayment rule, we set repaymentsStartingFromDate (which will be used as seed date later)
+ // If calculated repayment start date does not match due to minimum days between
+ // disbursal and first
+ // repayment rule, we set repaymentsStartingFromDate (which will be used as seed
+ // date later)
Review Comment:
> unnecessary change
Understood. I have reverted the formatting changes and removed the meta-comments to keep the diff minimal and focused strictly on the logic extract
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2464: Refactor LoanScheduleAssembler logic extraction [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5438:
URL: https://github.com/apache/fineract/pull/5438#discussion_r2773176499
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleAssembler.java:
##########
@@ -748,18 +750,10 @@ public LoanScheduleModel assembleLoanScheduleFrom(final LoanApplicationTerms loa
final MathContext mc = MoneyHelper.getMathContext();
HolidayDetailDTO detailDTO = new HolidayDetailDTO(isHolidayEnabled, holidays, workingDays);
- LoanScheduleGenerator loanScheduleGenerator = this.loanScheduleFactory.create(loanApplicationTerms.getLoanScheduleType(),
- loanApplicationTerms.getInterestMethod());
+ // REFACTORED: Removed redundant initialization and extracted logic
Review Comment:
We dont want such comments. Please remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2464: Refactor LoanScheduleAssembler logic extraction [fineract]
Posted by "Saifulhuq01 (via GitHub)" <gi...@apache.org>.
Saifulhuq01 commented on PR #5438:
URL: https://github.com/apache/fineract/pull/5438#issuecomment-3882842900
@adamsaghy I’ve verified the latest changes and the local build (including Spotless) is fully green tested.
This PR specifically addresses the LoanScheduleAssembler logic extraction (FINERACT-2464), improving modularity and maintainability in the loan schedule generation path.
Ready for merge whenever you have a moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2464: Refactor LoanScheduleAssembler logic extraction [fineract]
Posted by "Saifulhuq01 (via GitHub)" <gi...@apache.org>.
Saifulhuq01 commented on PR #5438:
URL: https://github.com/apache/fineract/pull/5438#issuecomment-3895671133
@adamsaghy
I’ve verified the diff is minimal and strictly limited to the logic extraction (no formatting noise). CI is green. I’d appreciate a final look when you have a moment next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2464: Refactor LoanScheduleAssembler logic extraction [fineract]
Posted by "Saifulhuq01 (via GitHub)" <gi...@apache.org>.
Saifulhuq01 commented on code in PR #5438:
URL: https://github.com/apache/fineract/pull/5438#discussion_r2773410549
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleAssembler.java:
##########
@@ -748,18 +750,10 @@ public LoanScheduleModel assembleLoanScheduleFrom(final LoanApplicationTerms loa
final MathContext mc = MoneyHelper.getMathContext();
HolidayDetailDTO detailDTO = new HolidayDetailDTO(isHolidayEnabled, holidays, workingDays);
- LoanScheduleGenerator loanScheduleGenerator = this.loanScheduleFactory.create(loanApplicationTerms.getLoanScheduleType(),
- loanApplicationTerms.getInterestMethod());
+ // REFACTORED: Removed redundant initialization and extracted logic
Review Comment:
> We dont want such comments. Please remove
done @adamsaghy kindly check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2464: Refactor LoanScheduleAssembler logic extraction [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5438:
URL: https://github.com/apache/fineract/pull/5438#discussion_r2792584864
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleAssembler.java:
##########
@@ -314,8 +314,10 @@ private LoanApplicationTerms assembleLoanApplicationTermsFrom(final JsonElement
calculatedRepaymentsStartingFromDate = deriveFirstRepaymentDate(loanType, repaymentEvery, expectedDisbursementDate,
repaymentPeriodFrequencyType, loanProduct.getMinimumDaysBetweenDisbursalAndFirstRepayment(), calendar, submittedOnDate,
repaymentStartDateType);
- // If calculated repayment start date does not match due to minimum days between disbursal and first
- // repayment rule, we set repaymentsStartingFromDate (which will be used as seed date later)
+ // If calculated repayment start date does not match due to minimum days between
+ // disbursal and first
+ // repayment rule, we set repaymentsStartingFromDate (which will be used as seed
+ // date later)
Review Comment:
unnecessary change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org