[GitHub] gigasquid edited a comment on issue #13559: fix for opencv4

[GitBox <gi...@apache.org>]

gigasquid edited a comment on issue #13559: fix for opencv4
URL: https://github.com/apache/incubator-mxnet/pull/13559#issuecomment-453306554
 
 
   on OSX  - I cannot do a make without errors due to `package opencv not found’. 
   
   ```Package opencv was not found in the pkg-config search path.
   Perhaps you should add the directory containing `opencv.pc'
   to the PKG_CONFIG_PATH environment variable
   No package 'opencv' found
   ```
   
   and 
   
   ```src/imperative/../profiler/./profiler.h:1186:8: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
         [this](OprExecStat *stat) {}, name_.c_str(), dev_type_, dev_id_,
          ^
   In file included from src/io/image_aug_default.cc:31:
   src/io/./image_augmenter.h:31:10: fatal error: 'opencv2/opencv.hpp' file not found
   #include <opencv2/opencv.hpp>
   ```
   
   This is because as @wkcn said above the pkg name has changed to `opencv4` from `opencv`
   
   ```
   ls -l /usr/local/lib/pkgconfig
   opencv4.pc -> ../../Cellar/opencv/4.0.1/lib/pkgconfig/opencv4.pc
   ```
   
   If I make the changes to the Makefile that @wkcn suggested to change it to opencv4, everything works - however we would also need to change all the CI files to bump opencv as well as coordinate changing building of nightly distributions
   cc @marcoabreu @lanking520 
   
   Maybe we could put a switch in the Makefile or another config to specify what version of opencv you have? That way we could make the upgrade path easier.
   
   Could the makefile somehow detect what version of opencv you have?
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services