[GitHub] [beam] TheNeuralBit commented on a change in pull request #14328: [BEAM-12069] Make mock a test-only dependency

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #14328:
URL: https://github.com/apache/beam/pull/14328#discussion_r603643643



##########
File path: sdks/python/setup.py
##########
@@ -146,7 +146,7 @@ def get_version():
     'grpcio>=1.29.0,<2',
     'hdfs>=2.1.0,<3.0.0',
     'httplib2>=0.8,<0.18.0',
-    'mock>=1.0.1,<3.0.0',

Review comment:
       Thanks @potiuk, good to know this will help airflow as well :)
   
   I filed BEAM-12069 to track the issue fixed by this PR, BEAM-11167 would be the appropriate jira for the dill issue. I don't think there's any reason not to go ahead and upgrade it, we just have it pinned to a narrow range to avoid compatibility issues (e.g. see BEAM-4785). Would you be interested in trying to upgrade dill to 0.3.2 or 0.3.3?

##########
File path: sdks/python/setup.py
##########
@@ -167,6 +166,7 @@ def get_version():
 
 REQUIRED_TEST_PACKAGES = [
     'freezegun>=0.3.12',
+    'mock>=1.0.1',

Review comment:
       ```suggestion
       'mock>=1.0.1<3.0.0',
   ```
   
   Let's keep the upper bound for now to minimize the diff. Just making it a test dependency should address the TF 
   and airflow issues. Updating the dep is tracked separately in BEAM-7369.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org