You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by oxygen311 <gi...@git.apache.org> on 2018/07/06 15:23:07 UTC
[GitHub] zeppelin pull request #3057: [Zeppelin 3582] Add type data to result of quer...
GitHub user oxygen311 opened a pull request:
https://github.com/apache/zeppelin/pull/3057
[Zeppelin 3582] Add type data to result of query from SQL
### What is this PR for?
JDBCInterpreter knows type information for every SQL Query. We could save this info to pool and use it.
There are three types of table column:
- Number;
- String;
- Date.
### What type of PR is it?
Improvement
### What is the Jira issue?
[Zeppelin 3582](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3582)
### Screenshots
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3582
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3057.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3057
----
----
---
[GitHub] zeppelin pull request #3057: [ZEPPELIN 3582] Add type data to result of quer...
Posted by oxygen311 <gi...@git.apache.org>.
GitHub user oxygen311 reopened a pull request:
https://github.com/apache/zeppelin/pull/3057
[ZEPPELIN 3582] Add type data to result of query from SQL
### What is this PR for?
JDBCInterpreter knows type information for every SQL Query. We could save this info to pool and use it.
There are three types of table column:
- Number;
- String;
- Date.
### What type of PR is it?
Improvement
### What is the Jira issue?
[Zeppelin 3582](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3582)
### Screenshots
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3582
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3057.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3057
----
commit 5cd8d6d2b1bb2ea795824b0706b3b9bb4af1868f
Author: oxygen311 <al...@...>
Date: 2018-07-05T08:11:48Z
Extend InterpreterResultMessage for holds it's results type information
commit 86c76a9b76ffabb3874c365929fb1df88c92de4b
Author: oxygen311 <al...@...>
Date: 2018-07-05T09:18:12Z
Added the ability for JDBCInterpreter to export types of it's data
commit 235b27a3360060ea44485c6135b53dad459dc6a0
Author: oxygen311 <al...@...>
Date: 2018-07-05T09:45:53Z
Fix %table issue for passing tests (%table don't actually exists in result msg string and must be dropped)
commit 50141d2f2af20bea8d33ee6b5b6eec7996a394ae
Author: oxygen311 <al...@...>
Date: 2018-07-05T10:39:02Z
Add tests for column type information
commit 15212e811177b0679157b3a0bca48622911dfef4
Author: oxygen311 <al...@...>
Date: 2018-07-05T11:25:18Z
Add type info information to resource pool
commit 1f055f35740d83325ed788698881aed010458caf
Author: oxygen311 <al...@...>
Date: 2018-07-06T10:12:51Z
Add class for message column type information.
commit def58011c9b76425244b0b6251c694902d82ac7c
Author: oxygen311 <al...@...>
Date: 2018-07-06T11:33:47Z
Add new class JDBCUtils with JDBCInterpreter's static methods
commit 018c3319ec5c6c60afe14dfb3d92a44689aa9af0
Author: oxygen311 <al...@...>
Date: 2018-07-06T12:12:31Z
Fix tests
commit b1511214d638630b71ce7dc816c13a534b8e27c5
Author: oxygen311 <al...@...>
Date: 2018-07-09T08:47:43Z
Add new class JDBCUtils with JDBCInterpreter's static methods
commit fe75ae677e0f63e51d2340fcacb3f40d17371bf1
Author: oxygen311 <al...@...>
Date: 2018-07-09T08:47:43Z
Fix `InterpreterResultMessage` constructor
commit 36632cb0af29e08a44804c5187109a8c35f5a776
Author: oxygen311 <al...@...>
Date: 2018-07-09T08:54:12Z
Merge remote-tracking branch 'tinkoff/ZEPPELIN-3582' into ZEPPELIN-3582
commit 12f86927ff2e38da76b3533db0f0ac24d17cfede
Author: oxygen311 <al...@...>
Date: 2018-07-09T09:07:20Z
Store only `List<ColumnDef.TYPE>` in `InterpreterResultMessage`
----
---
[GitHub] zeppelin issue #3057: [ZEPPELIN 3582] Add type data to result of query from ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3057
This is nice feature, could we also pass this kind of meta info to frontend ? so that frontend can display the data more intelligently.
---
[GitHub] zeppelin issue #3057: [ZEPPELIN-3582] Add type data to result of query from ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3057
It seems to be ready to merge.
---
[GitHub] zeppelin issue #3057: [ZEPPELIN 3582] Add type data to result of query from ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3057
Thanks. Can you restart the failed one:
https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/401673653
---
[GitHub] zeppelin pull request #3057: [ZEPPELIN 3582] Add type data to result of quer...
Posted by oxygen311 <gi...@git.apache.org>.
Github user oxygen311 closed the pull request at:
https://github.com/apache/zeppelin/pull/3057
---
[GitHub] zeppelin issue #3057: [ZEPPELIN 3582] Add type data to result of query from ...
Posted by oxygen311 <gi...@git.apache.org>.
Github user oxygen311 commented on the issue:
https://github.com/apache/zeppelin/pull/3057
@zjffdu we plan to do it in next pool requests.
---
[GitHub] zeppelin pull request #3057: [ZEPPELIN-3582] Add type data to result of quer...
Posted by oxygen311 <gi...@git.apache.org>.
GitHub user oxygen311 reopened a pull request:
https://github.com/apache/zeppelin/pull/3057
[ZEPPELIN-3582] Add type data to result of query from SQL
### What is this PR for?
JDBCInterpreter knows type information for every SQL Query. We could save this info to pool and use it.
There are three types of table column:
- Number;
- String;
- Date.
### What type of PR is it?
Improvement
### What is the Jira issue?
[Zeppelin 3582](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3582)
### Screenshots
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3582
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3057.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3057
----
commit 5cd8d6d2b1bb2ea795824b0706b3b9bb4af1868f
Author: oxygen311 <al...@...>
Date: 2018-07-05T08:11:48Z
Extend InterpreterResultMessage for holds it's results type information
commit 86c76a9b76ffabb3874c365929fb1df88c92de4b
Author: oxygen311 <al...@...>
Date: 2018-07-05T09:18:12Z
Added the ability for JDBCInterpreter to export types of it's data
commit 235b27a3360060ea44485c6135b53dad459dc6a0
Author: oxygen311 <al...@...>
Date: 2018-07-05T09:45:53Z
Fix %table issue for passing tests (%table don't actually exists in result msg string and must be dropped)
commit 50141d2f2af20bea8d33ee6b5b6eec7996a394ae
Author: oxygen311 <al...@...>
Date: 2018-07-05T10:39:02Z
Add tests for column type information
commit 15212e811177b0679157b3a0bca48622911dfef4
Author: oxygen311 <al...@...>
Date: 2018-07-05T11:25:18Z
Add type info information to resource pool
commit 1f055f35740d83325ed788698881aed010458caf
Author: oxygen311 <al...@...>
Date: 2018-07-06T10:12:51Z
Add class for message column type information.
commit def58011c9b76425244b0b6251c694902d82ac7c
Author: oxygen311 <al...@...>
Date: 2018-07-06T11:33:47Z
Add new class JDBCUtils with JDBCInterpreter's static methods
commit 018c3319ec5c6c60afe14dfb3d92a44689aa9af0
Author: oxygen311 <al...@...>
Date: 2018-07-06T12:12:31Z
Fix tests
commit b1511214d638630b71ce7dc816c13a534b8e27c5
Author: oxygen311 <al...@...>
Date: 2018-07-09T08:47:43Z
Add new class JDBCUtils with JDBCInterpreter's static methods
commit fe75ae677e0f63e51d2340fcacb3f40d17371bf1
Author: oxygen311 <al...@...>
Date: 2018-07-09T08:47:43Z
Fix `InterpreterResultMessage` constructor
commit 36632cb0af29e08a44804c5187109a8c35f5a776
Author: oxygen311 <al...@...>
Date: 2018-07-09T08:54:12Z
Merge remote-tracking branch 'tinkoff/ZEPPELIN-3582' into ZEPPELIN-3582
commit 12f86927ff2e38da76b3533db0f0ac24d17cfede
Author: oxygen311 <al...@...>
Date: 2018-07-09T09:07:20Z
Store only `List<ColumnDef.TYPE>` in `InterpreterResultMessage`
commit 4b1abd1e51915d4e1b2aa9ad135396e7201df751
Author: oxygen311 <al...@...>
Date: 2018-07-13T10:12:21Z
Add finally block in tests
commit 14a546be4c9edfd4cc8604a4d1197bd8c03107c7
Author: oxygen311 <al...@...>
Date: 2018-07-13T12:47:25Z
Fix line length
----
---
[GitHub] zeppelin pull request #3057: [ZEPPELIN-3582] Add type data to result of quer...
Posted by oxygen311 <gi...@git.apache.org>.
Github user oxygen311 closed the pull request at:
https://github.com/apache/zeppelin/pull/3057
---
[GitHub] zeppelin issue #3057: [ZEPPELIN-3582] Add type data to result of query from ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3057
Got it. I wonder the status of this PR
---
[GitHub] zeppelin issue #3057: [ZEPPELIN-3582] Add type data to result of query from ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3057
Sorry, I need go through it again today.
---
[GitHub] zeppelin issue #3057: [Zeppelin 3582] Add type data to result of query from ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3057
Great!! Thank you!
---
[GitHub] zeppelin pull request #3057: [ZEPPELIN-3582] Add type data to result of quer...
Posted by oxygen311 <gi...@git.apache.org>.
Github user oxygen311 closed the pull request at:
https://github.com/apache/zeppelin/pull/3057
---