[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #7125: Fix UpsertConfig JSON deserialization.

[GitBox <gi...@apache.org>]

amrishlal commented on a change in pull request #7125:
URL: https://github.com/apache/incubator-pinot/pull/7125#discussion_r663665842



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java
##########
@@ -37,18 +39,15 @@
     APPEND, INCREMENT, OVERWRITE, UNION
   }
 
+  @JsonPropertyDescription("Upsert mode.")
   private final Mode _mode;
-  private final Map<String, Strategy> _partialUpsertStrategies;
 
-  public UpsertConfig(@JsonProperty(value = "mode", required = true) Mode mode) {

Review comment:
       I don't think changing the body of the constructor will do anything. The error was more about not being able to find a constructor with sufficient properties even though one was available.To avoid confusion, it's probably best to have only constructor with all properties. This class was the exception as other `BaseJsonConfig` derived classes are declaring only one constructor.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org