You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "AshharAhmadKhan (via GitHub)" <gi...@apache.org> on 2026/05/15 18:28:21 UTC

[PR] FINERACT-2602: Remove stuck loans from loan lock table after COB execution [fineract]

AshharAhmadKhan opened a new pull request, #5853:
URL: https://github.com/apache/fineract/pull/5853

   Fixes an issue where loan accounts remain stuck in `m_loan_account_locks` after COB completes successfully.
   
   Adds `UnlockProcessedLoansTasklet` as the final step in the COB job. It removes orphaned locks where the loan was fully processed (error is null and `lock_placed_on_cob_business_date` matches the current COB date).
   
   Also adds a Cucumber unit test for the new tasklet.
   
   Resolves: https://issues.apache.org/jira/browse/FINERACT-2602


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2602: Remove stuck loans from loan lock table after COB execution [fineract]

Posted by "AshharAhmadKhan (via GitHub)" <gi...@apache.org>.
AshharAhmadKhan commented on PR #5853:
URL: https://github.com/apache/fineract/pull/5853#issuecomment-4469610526

   Hey @adamsaghy Please trigger checks when you get a chance, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2602: Remove stuck loans from loan lock table after COB execution [fineract]

Posted by "AshharAhmadKhan (via GitHub)" <gi...@apache.org>.
AshharAhmadKhan commented on PR #5853:
URL: https://github.com/apache/fineract/pull/5853#issuecomment-4488795558

   Thanks @adamsaghy.
   
   I took a closer look at #5858, and I agree it’s a better approach than mine for handling this issue. I’ll close this PR to avoid duplicate effort.
   
   Glad I got to work on this and understand this part of the COB flow better. I’ll also drop my thoughts/review on #5858 where I think I can help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2602: Remove stuck loans from loan lock table after COB execution [fineract]

Posted by "AshharAhmadKhan (via GitHub)" <gi...@apache.org>.
AshharAhmadKhan commented on PR #5853:
URL: https://github.com/apache/fineract/pull/5853#issuecomment-4488130983

   Hi @adamsaghy , just following up on this PR. Would appreciate a review when you get a chance, Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2602: Remove stuck loans from loan lock table after COB execution [fineract]

Posted by "AshharAhmadKhan (via GitHub)" <gi...@apache.org>.
AshharAhmadKhan commented on PR #5853:
URL: https://github.com/apache/fineract/pull/5853#issuecomment-4470711780

   @adamsaghy Hey, Can you please retrigger failing checks. Both were flaky.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2602: Remove stuck loans from loan lock table after COB execution [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5853:
URL: https://github.com/apache/fineract/pull/5853#issuecomment-4488166384

   @AshharAhmadKhan I believe you have got a contender: https://github.com/apache/fineract/pull/5858 with a more thorough approach and testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2602: Remove stuck loans from loan lock table after COB execution [fineract]

Posted by "AshharAhmadKhan (via GitHub)" <gi...@apache.org>.
AshharAhmadKhan closed pull request #5853: FINERACT-2602: Remove stuck loans from loan lock table after COB execution
URL: https://github.com/apache/fineract/pull/5853


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org