You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2014/05/27 01:51:44 UTC

svn commit: r1597667 - in /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins: util/PluginBuilder.java visitors/PluginVisitorRegistry.java visitors/PluginVisitors.java

Author: mattsicker
Date: Mon May 26 23:51:44 2014
New Revision: 1597667

URL: http://svn.apache.org/r1597667
Log:
Rename PluginVisitors to PluginVisitorRegistry as suggested on the ML.

Added:
    logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitorRegistry.java
      - copied, changed from r1597632, logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitors.java
Removed:
    logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitors.java
Modified:
    logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginBuilder.java

Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginBuilder.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginBuilder.java?rev=1597667&r1=1597666&r2=1597667&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginBuilder.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginBuilder.java Mon May 26 23:51:44 2014
@@ -34,7 +34,7 @@ import org.apache.logging.log4j.core.con
 import org.apache.logging.log4j.core.config.plugins.PluginBuilderFactory;
 import org.apache.logging.log4j.core.config.plugins.PluginFactory;
 import org.apache.logging.log4j.core.config.plugins.visitors.PluginVisitor;
-import org.apache.logging.log4j.core.config.plugins.visitors.PluginVisitors;
+import org.apache.logging.log4j.core.config.plugins.visitors.PluginVisitorRegistry;
 import org.apache.logging.log4j.core.util.Assert;
 import org.apache.logging.log4j.core.util.Builder;
 import org.apache.logging.log4j.status.StatusLogger;
@@ -163,7 +163,8 @@ public class PluginBuilder<T> implements
                 if (a instanceof PluginAliases) {
                     continue; // already processed
                 }
-                final PluginVisitor<? extends Annotation> visitor = PluginVisitors.findVisitor(a.annotationType());
+                final PluginVisitor<? extends Annotation> visitor =
+                    PluginVisitorRegistry.findVisitor(a.annotationType());
                 if (visitor != null) {
                     final Object value = visitor.setAliases(aliases)
                         .setAnnotation(a)
@@ -199,7 +200,8 @@ public class PluginBuilder<T> implements
                 if (a instanceof PluginAliases) {
                     continue; // already processed
                 }
-                final PluginVisitor<? extends Annotation> visitor = PluginVisitors.findVisitor(a.annotationType());
+                final PluginVisitor<? extends Annotation> visitor = PluginVisitorRegistry.findVisitor(
+                    a.annotationType());
                 if (visitor != null) {
                     args[i] = visitor.setAliases(aliases)
                         .setAnnotation(a)

Copied: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitorRegistry.java (from r1597632, logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitors.java)
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitorRegistry.java?p2=logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitorRegistry.java&p1=logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitors.java&r1=1597632&r2=1597667&rev=1597667&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitors.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitorRegistry.java Mon May 26 23:51:44 2014
@@ -33,7 +33,7 @@ import org.apache.logging.log4j.status.S
 /**
  * Registry for associating Plugin annotations with PluginVisitor implementations.
  */
-public final class PluginVisitors {
+public final class PluginVisitorRegistry {
 
     private static final Logger LOGGER = StatusLogger.getLogger();
 
@@ -53,7 +53,7 @@ public final class PluginVisitors {
         registerVisitor(PluginElement.class, PluginElementVisitor.class);
     }
 
-    private PluginVisitors() {
+    private PluginVisitorRegistry() {
     }
 
     /**