[jira] [Commented] (MBUILDCACHE-37) Allow disabled-by-default configuration

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MBUILDCACHE-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687290#comment-17687290 ] 

ASF GitHub Bot commented on MBUILDCACHE-37:
-------------------------------------------

ahus1 commented on PR #37:
URL: https://github.com/apache/maven-build-cache-extension/pull/37#issuecomment-1426353520

   I'm happy to see those approvals above. Once this is merged and available as a release (even a pre-release), I'll be able to canary-test this with some users on our project. Let me know how I can help. Thanks!




> Allow disabled-by-default configuration
> ---------------------------------------
>
>                 Key: MBUILDCACHE-37
>                 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-37
>             Project: Maven Build Cache Extension
>          Issue Type: Improvement
>          Components: remote build cache
>    Affects Versions: 1.0.0
>            Reporter: Alexander Schwartz
>            Priority: Major
>              Labels: pull-request-available
>
> I'm trying to create a configuration where the extension is disabled by default and can be enabled by some key users as a opt-in. 
> My first attempt: 
>  * in the XML, set `cache.configuration.enabled` to `false`
> -> This disables it by default
>  * On the CLI, set `-Dmaven.build.cache.enabled=true`
> -> This was intended to enable it "opt in" - but failed, see below.
> The problem: 
> The code in
> [https://github.com/apache/maven-build-cache-extension/blob/2d262e133749abb5163969b9c0b2f0f2056e7951/src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java#L181-L184]
> will use the "disable" state in the XML. 
> Suggested change: `maven.build.cache.enabled` should override the setting `cache.configuration.enabled` in the XML. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)