You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Malarg (via GitHub)" <gi...@apache.org> on 2023/03/22 11:15:42 UTC
[GitHub] [beam] Malarg opened a new pull request, #25925: Issue25640 tour of beam integration tests
Malarg opened a new pull request, #25925:
URL: https://github.com/apache/beam/pull/25925
tour of beam integration tests
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25925: Issue25640 tour of beam integration tests
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25925:
URL: https://github.com/apache/beam/pull/25925#issuecomment-1479456929
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on a diff in pull request #25925: Issue25640 tour of beam integration tests
Posted by "alexeyinkin (via GitHub)" <gi...@apache.org>.
alexeyinkin commented on code in PR #25925:
URL: https://github.com/apache/beam/pull/25925#discussion_r1144645677
##########
.github/workflows/tour_of_beam_frontend_test.yml:
##########
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Tour Of Beam Fronend Test
+
+on:
+ push:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+ pull_request:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+ workflow_dispatch:
Review Comment:
Delete.
##########
playground/frontend/playground_components_dev/lib/src/common_tests/toggle_brightness_mode_test.dart:
##########
@@ -18,7 +18,8 @@
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
-import 'package:playground_components_dev/playground_components_dev.dart';
+
+import '../../playground_components_dev.dart';
Review Comment:
Please import specific files.
##########
learning/tour-of-beam/frontend/integration_test/tour_page_test.dart:
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:get_it/get_it.dart';
+import 'package:integration_test/integration_test.dart';
+import 'package:playground_components/playground_components.dart';
+import 'package:playground_components_dev/playground_components_dev.dart';
+import 'package:tour_of_beam/cache/content_tree.dart';
+import 'package:tour_of_beam/components/builders/content_tree.dart';
+import 'package:tour_of_beam/models/group.dart';
+import 'package:tour_of_beam/models/module.dart';
+import 'package:tour_of_beam/models/node.dart';
+import 'package:tour_of_beam/models/unit.dart';
+import 'package:tour_of_beam/pages/tour/screen.dart';
+import 'package:tour_of_beam/pages/tour/widgets/unit.dart';
+import 'package:tour_of_beam/pages/tour/widgets/unit_content.dart';
+
+import 'common/common.dart';
+import 'common/common_finders.dart';
+
+void main() {
+ IntegrationTestWidgetsFlutterBinding.ensureInitialized();
+ testWidgets(
+ 'ToB miscellaneous ui',
+ (wt) async {
+ await init(wt);
+ await wt.tapAndSettle(find.text(Sdk.java.title));
+ await wt.tapAndSettle(find.startTourButton());
+
+ await _checkContentTreeBuildsProperly(wt);
+ await _checkUnitContentLoadsProperly(wt);
+ await _checkContentTreeScrollsProperly(wt);
+ await _checkHighlightsSelectedUnit(wt);
+ await _checkRunCodeWorks(wt);
+ await _checkResizeUnitContent(wt);
+ },
+ );
+}
+
+Future<void> _checkContentTreeBuildsProperly(WidgetTester wt) async {
+ final modules = _getModules(wt);
+
+ for (final module in modules) {
+ await _checkModule(module, wt);
+ }
+}
+
+List<ModuleModel> _getModules(WidgetTester wt) {
+ final contentTreeCache = GetIt.instance.get<ContentTreeCache>();
+ final controller = getContentTreeController(wt);
+ final contentTree = contentTreeCache.getContentTree(controller.sdkId);
+ return contentTree?.modules ?? (throw Exception('Can not load moduled'));
+}
+
+Future<void> _checkModule(ModuleModel module, WidgetTester wt) async {
+ for (final node in module.nodes) {
+ if (node is UnitModel) {
+ _checkNode(node);
+ }
+ if (node is GroupModel) {
+ await _checkGroup(node, wt);
+ }
+ }
+}
+
+void _checkNode(NodeModel node) {
+ expect(
+ find.descendant(
+ of: find.byType(ContentTreeBuilder),
+ matching: find.text(node.title),
+ ),
+ findsAtLeastNWidgets(1),
+ );
+}
+
+Future<void> _checkGroup(GroupModel group, WidgetTester wt) async {
+ final contentTreeController = getContentTreeController(wt);
+ contentTreeController.expandGroup(group);
Review Comment:
Can you mimic a click on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Malarg commented on pull request #25925: tour of beam integration tests
Posted by "Malarg (via GitHub)" <gi...@apache.org>.
Malarg commented on PR #25925:
URL: https://github.com/apache/beam/pull/25925#issuecomment-1484777150
@damondouglas bottom overflowed error will be fixed here: https://github.com/apache/beam/pull/25964
Also I didn't got flutter_01.log file after executing integration tests. If the file will be generated at your machine again, please attach it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #25925: tour of beam integration tests
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #25925:
URL: https://github.com/apache/beam/pull/25925#issuecomment-1529824169
Run Python_Integration PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on a diff in pull request #25925: tour of beam integration tests
Posted by "damondouglas (via GitHub)" <gi...@apache.org>.
damondouglas commented on code in PR #25925:
URL: https://github.com/apache/beam/pull/25925#discussion_r1148124569
##########
.github/workflows/tour_of_beam_frontend_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Tour Of Beam Fronend Test
+
+on:
+ push:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+ pull_request:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ tour_of_beam_test:
+ name: Tour of Beam Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.7.3'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ run: |
+ cd playground/frontend/playground_components && flutter pub get && cd -
+ cd playground/frontend/playground_components_dev && flutter pub get && cd -
+ cd learning/tour-of-beam/frontend && flutter pub get && cd -
Review Comment:
These need to be in the learning/tour-of-beam/frontend README.
##########
.github/workflows/tour_of_beam_frontend_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Tour Of Beam Fronend Test
+
+on:
+ push:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+ pull_request:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ tour_of_beam_test:
+ name: Tour of Beam Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.7.3'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ run: |
+ cd playground/frontend/playground_components && flutter pub get && cd -
+ cd playground/frontend/playground_components_dev && flutter pub get && cd -
+ cd learning/tour-of-beam/frontend && flutter pub get && cd -
+
+# - name: 'Formatting'
+# run: dart format --output=none --set-exit-if-changed .
+
+# - name: 'Analyze playground_components'
+# working-directory: playground/frontend/playground_components
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground_components_dev'
+# working-directory: playground/frontend/playground_components_dev
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground'
+# working-directory: playground/frontend
+# run: dart analyze --fatal-infos lib test
+
+ # - name: 'Test tour of beam'
+ # working-directory: learning/tour-of-beam/frontend
+ # run: flutter test
+
+ - uses: nanasess/setup-chromedriver@v1
+
+ - name: 'Integration tests'
+ run: |
+ chromedriver --port=4444 &
+ ./gradlew :learning:tour-of-beam:frontend:integrationTest -PdeviceId=web-server
Review Comment:
This needs to go into the tob frontend README.
##########
.github/workflows/tour_of_beam_frontend_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Tour Of Beam Fronend Test
+
+on:
+ push:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+ pull_request:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ tour_of_beam_test:
+ name: Tour of Beam Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.7.3'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ run: |
+ cd playground/frontend/playground_components && flutter pub get && cd -
+ cd playground/frontend/playground_components_dev && flutter pub get && cd -
+ cd learning/tour-of-beam/frontend && flutter pub get && cd -
+
+# - name: 'Formatting'
+# run: dart format --output=none --set-exit-if-changed .
+
+# - name: 'Analyze playground_components'
+# working-directory: playground/frontend/playground_components
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground_components_dev'
+# working-directory: playground/frontend/playground_components_dev
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground'
+# working-directory: playground/frontend
+# run: dart analyze --fatal-infos lib test
+
+ # - name: 'Test tour of beam'
+ # working-directory: learning/tour-of-beam/frontend
+ # run: flutter test
Review Comment:
Please delete instead of commenting out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Malarg commented on a diff in pull request #25925: tour of beam integration tests
Posted by "Malarg (via GitHub)" <gi...@apache.org>.
Malarg commented on code in PR #25925:
URL: https://github.com/apache/beam/pull/25925#discussion_r1149007464
##########
.github/workflows/tour_of_beam_frontend_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Tour Of Beam Fronend Test
+
+on:
+ push:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+ pull_request:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ tour_of_beam_test:
+ name: Tour of Beam Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.7.3'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ run: |
+ cd playground/frontend/playground_components && flutter pub get && cd -
+ cd playground/frontend/playground_components_dev && flutter pub get && cd -
+ cd learning/tour-of-beam/frontend && flutter pub get && cd -
+
+# - name: 'Formatting'
+# run: dart format --output=none --set-exit-if-changed .
+
+# - name: 'Analyze playground_components'
+# working-directory: playground/frontend/playground_components
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground_components_dev'
+# working-directory: playground/frontend/playground_components_dev
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground'
+# working-directory: playground/frontend
+# run: dart analyze --fatal-infos lib test
+
+ # - name: 'Test tour of beam'
+ # working-directory: learning/tour-of-beam/frontend
+ # run: flutter test
+
+ - uses: nanasess/setup-chromedriver@v1
+
+ - name: 'Integration tests'
+ run: |
+ chromedriver --port=4444 &
+ ./gradlew :learning:tour-of-beam:frontend:integrationTest -PdeviceId=web-server
Review Comment:
added
##########
.github/workflows/tour_of_beam_frontend_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Tour Of Beam Fronend Test
+
+on:
+ push:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+ pull_request:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ tour_of_beam_test:
+ name: Tour of Beam Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.7.3'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ run: |
+ cd playground/frontend/playground_components && flutter pub get && cd -
+ cd playground/frontend/playground_components_dev && flutter pub get && cd -
+ cd learning/tour-of-beam/frontend && flutter pub get && cd -
Review Comment:
added
##########
.github/workflows/tour_of_beam_frontend_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Tour Of Beam Fronend Test
+
+on:
+ push:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+ pull_request:
+ paths: ['learning/tour-of-beam/frontend/**', 'playground/frontend/playground_components']
+ branches: ['**']
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ tour_of_beam_test:
+ name: Tour of Beam Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.7.3'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ run: |
+ cd playground/frontend/playground_components && flutter pub get && cd -
+ cd playground/frontend/playground_components_dev && flutter pub get && cd -
+ cd learning/tour-of-beam/frontend && flutter pub get && cd -
+
+# - name: 'Formatting'
+# run: dart format --output=none --set-exit-if-changed .
+
+# - name: 'Analyze playground_components'
+# working-directory: playground/frontend/playground_components
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground_components_dev'
+# working-directory: playground/frontend/playground_components_dev
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground'
+# working-directory: playground/frontend
+# run: dart analyze --fatal-infos lib test
+
+ # - name: 'Test tour of beam'
+ # working-directory: learning/tour-of-beam/frontend
+ # run: flutter test
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #25925: tour of beam integration tests
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #25925:
URL: https://github.com/apache/beam/pull/25925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25925: Issue25640 tour of beam integration tests
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25925:
URL: https://github.com/apache/beam/pull/25925#issuecomment-1481030481
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on a diff in pull request #25925: tour of beam integration tests
Posted by "alexeyinkin (via GitHub)" <gi...@apache.org>.
alexeyinkin commented on code in PR #25925:
URL: https://github.com/apache/beam/pull/25925#discussion_r1181602189
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -22,7 +22,6 @@ on:
pull_request:
paths: ['playground/frontend/**']
branches: ['**']
- workflow_dispatch:
Review Comment:
That was accidental. Re-enabled, added for Tour of Beam as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #25925: tour of beam integration tests
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #25925:
URL: https://github.com/apache/beam/pull/25925#discussion_r1180712271
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -22,7 +22,6 @@ on:
pull_request:
paths: ['playground/frontend/**']
branches: ['**']
- workflow_dispatch:
Review Comment:
Any reason to remove this?
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -22,7 +22,6 @@ on:
pull_request:
paths: ['playground/frontend/**']
branches: ['**']
- workflow_dispatch:
Review Comment:
(and not have this as an option for tour_of_beam)
##########
.github/workflows/tour_of_beam_frontend_test.yml:
##########
@@ -0,0 +1,65 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Tour Of Beam Fronend Test
Review Comment:
```suggestion
name: Tour Of Beam Frontend Test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25925: tour of beam integration tests
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25925:
URL: https://github.com/apache/beam/pull/25925#issuecomment-1516223899
Reminder, please take a look at this pr: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #25925: Issue25640 tour of beam integration tests
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #25925:
URL: https://github.com/apache/beam/pull/25925#issuecomment-1479402828
## [Codecov](https://codecov.io/gh/apache/beam/pull/25925?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#25925](https://codecov.io/gh/apache/beam/pull/25925?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf31f9e) into [master](https://codecov.io/gh/apache/beam/commit/ca0787642a6b3804a742326147281c99ae8d08d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca07876) will **decrease** coverage by `1.37%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #25925 +/- ##
==========================================
- Coverage 72.79% 71.42% -1.37%
==========================================
Files 776 778 +2
Lines 102909 102420 -489
==========================================
- Hits 74914 73156 -1758
- Misses 26540 27809 +1269
Partials 1455 1455
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `79.97% <ø> (-1.98%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 39 files with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/25925/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on pull request #25925: tour of beam integration tests
Posted by "alexeyinkin (via GitHub)" <gi...@apache.org>.
alexeyinkin commented on PR #25925:
URL: https://github.com/apache/beam/pull/25925#issuecomment-1525845129
Run Java PreCommit
Run Java_Examples_Dataflow PreCommit
Run Java_IOs_Direct PreCommit
Run Python_Integration PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org