[GitHub] [spark] zeruibao commented on a diff in pull request #41052: [SPARK-43380][SQL] Fix Avro data type conversion issues to avoid producing incorrect results

["zeruibao (via GitHub)" <gi...@apache.org>]

zeruibao commented on code in PR #41052:
URL: https://github.com/apache/spark/pull/41052#discussion_r1185721125


##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala:
##########
@@ -117,6 +118,20 @@ private[sql] class AvroDeserializer(
     val incompatibleMsg = errorPrefix +
         s"schema is incompatible (avroType = $avroType, sqlType = ${catalystType.sql})"
 
+    val realDataType = SchemaConverters.toSqlType(avroType).dataType
+    val confKey = SQLConf.LEGACY_AVRO_PREVENT_READING_INCORRECT_SAME_ENCODED_TYPES
+    val preventReadingIncorrectType = SQLConf.get.getConf(confKey)
+    def isNotExactType: Boolean = {
+      preventReadingIncorrectType && !realDataType.acceptsType(catalystType)

Review Comment:
   just try to use DataTypeUtils.sameType, which causes regression and fails some tests. So maybe still using acceptsType is better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org