You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/06/08 09:14:57 UTC
[GitHub] wu-sheng commented on a change in pull request #1331: modify the
document
wu-sheng commented on a change in pull request #1331: modify the document
URL: https://github.com/apache/incubator-skywalking/pull/1331#discussion_r193998527
##########
File path: docs/en/Deploy-skywalking-agent.md
##########
@@ -39,5 +39,10 @@ CATALINA_OPTS="$CATALINA_OPTS -javaagent:/path/to/skywalking-agent/skywalking-ag
- Tomcat 8
Change the first line of `tomcat/bin/catalina.sh`.
```shell
-set "CATALINA_OPTS=-javaagent:E:\apache-tomcat-8.5.20\skywalking-agent\skywalking-agent.jar"
-```
\ No newline at end of file
+set "CATALINA_OPTS=-javaagent:/path/to/skywalking-agent/skywalking-agent.jar"
+```
+- JAR file
+Change the boot command
Review comment:
I want to recommend you to change your English expression.
- My suggestion
Add `-javaagent` argument to command line in which you start your app. And make sure to add it before the -jar argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services