[GitHub] [incubator-eventmesh] mxsm commented on a diff in pull request #3044: [ISSUE #3028] Refactor ThreadFactory implement

["mxsm (via GitHub)" <gi...@apache.org>]

mxsm commented on code in PR #3044:
URL: https://github.com/apache/incubator-eventmesh/pull/3044#discussion_r1096618554


##########
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/common/TcpClient.java:
##########
@@ -75,8 +75,7 @@ public abstract class TcpClient implements Closeable {
     private transient ScheduledFuture<?> heartTask;
 
     protected static final ScheduledThreadPoolExecutor scheduler = new ScheduledThreadPoolExecutor(

Review Comment:
   I will fix those problems and resubmit this pr later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org