You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/08/12 16:06:39 UTC

[GitHub] [storm] agresch commented on a change in pull request #3323: STORM-3673 remove v1 built in metrics in favor of TaskMetrics

agresch commented on a change in pull request #3323:
URL: https://github.com/apache/storm/pull/3323#discussion_r469373981



##########
File path: storm-core/test/clj/org/apache/storm/metrics_test.clj
##########
@@ -238,143 +238,4 @@
       )))
 
 
-(deftest test-builtin-metrics-1

Review comment:
       No.  This seemed like an integration test.  I'm not sure how valuable this is.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org