You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Davide Giannella (JIRA)" <ji...@apache.org> on 2016/05/16 13:59:16 UTC

[jira] [Closed] (OAK-4266) NodeDocumentCache#get method should be synchronized

     [ https://issues.apache.org/jira/browse/OAK-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Davide Giannella closed OAK-4266.
---------------------------------

Bulk close for 1.5.2

> NodeDocumentCache#get method should be synchronized
> ---------------------------------------------------
>
>                 Key: OAK-4266
>                 URL: https://issues.apache.org/jira/browse/OAK-4266
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>            Reporter: Tomek Rękawek
>            Assignee: Tomek Rękawek
>             Fix For: 1.6, 1.5.2
>
>
> The {{NodeDocumentCache#get(String key, Callable)}} method may modify the cache if there's no value for the given {{key}}. Therefore, it should be synchronized using {{NodeDocumentLocks}}, as all the methods modifying the cache are.
> Right now, the {{get()}} method is invoked in 3 different places within the Oak codebase. All of them are critical sections anyway, so this modification won't result in a performance decrease.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)