You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by benson-basis <gi...@git.apache.org> on 2015/12/12 15:20:05 UTC
[GitHub] cxf pull request: CXF-6706 hibernate help
GitHub user benson-basis opened a pull request:
https://github.com/apache/cxf/pull/102
CXF-6706 hibernate help
I'm hoping to get some collaborative attention via this PR, as to why the test I added (and @Ignored) fails so spectacularly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benson-basis/cxf cxf-6706-hibernate-help
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/102.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #102
----
commit dccd12eb381d7403a09eb895aea36eaef604296d
Author: Benson Margulies <be...@basistech.com>
Date: 2015-12-11T21:06:17Z
try to add the helper to CXF.
commit f20f255406152ca563fbce717d0118a02bff6d58
Author: Benson Margulies <be...@basistech.com>
Date: 2015-12-11T23:38:08Z
Ignore the test.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by reta <gi...@git.apache.org>.
Github user reta commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164324664
@benson-basis Interesting, I pulled out your PR / branch, run tests and all of them are passed:
Any clues?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by tomitribe-dev <gi...@git.apache.org>.
Github user tomitribe-dev commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-218432570
Build finished. 697 tests run, 2 skipped, 0 failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #102: CXF-6706 hibernate help
Posted by deki <gi...@git.apache.org>.
Github user deki commented on the issue:
https://github.com/apache/cxf/pull/102
CXF-6706 is resolved so this should be closed as well, shouldn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #102: CXF-6706 hibernate help
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cxf/pull/102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by benson-basis <gi...@git.apache.org>.
Github user benson-basis commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164475385
Yes, and it's busted. It uses wrap, and karaf 4 refuses to start up if you
provision it as a bootFeature. For a 3.1.x change, I doubt that we want to
remove the feature. I have unwould the extra feature I added.
On Mon, Dec 14, 2015 at 10:56 AM, Christian Schneider <
notifications@github.com> wrote:
> I think we should not create our own feature for hibernate. There is
> already one:
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cxf/pull/102#issuecomment-164474590>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164478366
Ah yes I see there are two wrap entries ... still I think this does not belong into cxf.
I am especially concerned with the tight binding of the cxf validation to hibernate validator. I think CXF should be able to work with any validation provider and let the user choose which to install.
How about adding a correct hibernate 5 feature without wrap into the upcoming karaf 4.0.4?
I will take care of providing a fix to hibernate so their own feature is better in the next release.
I propose we only have the cxf-bean-validation feature in CXF. We can load the validation api using dependency=true. This way it should nicely interoperate with the hibernate validator feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by tomitribe-dev <gi...@git.apache.org>.
Github user tomitribe-dev commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-218431546
Build started sha1 is original commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cxf pull request: CXF-6706 hibernate help
Posted by Benson Margulies <bi...@gmail.com>.
Thanks. I also started a thread at servicemix; hypothetically, this is
all about the servicemix mission and CXF should just take advantage.
On Sun, Dec 13, 2015 at 9:07 AM, reta <gi...@git.apache.org> wrote:
> Github user reta commented on the pull request:
>
> https://github.com/apache/cxf/pull/102#issuecomment-164262300
>
> @benson-basis I'll try to help you out, @cschneider may have better idea about the issue.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by reta <gi...@git.apache.org>.
Github user reta commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164262300
@benson-basis I'll try to help you out, @cschneider may have better idea about the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by benson-basis <gi...@git.apache.org>.
Github user benson-basis commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164466569
I didn't know. I assumed that the SM stuff was there for a reason. That
will be my next port of call.
On Mon, Dec 14, 2015 at 10:21 AM, Christian Schneider <
notifications@github.com> wrote:
> Why do you use the hibernate bundle from servicemix?
> It looks like hibernate already provides a validator bundle:
>
> http://search.maven.org/#artifactdetails|org.hibernate|hibernate-validator-osgi|5.2.2.Final|pom
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cxf/pull/102#issuecomment-164464862>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by benson-basis <gi...@git.apache.org>.
Github user benson-basis commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164466763
Do you think I can then avoid the 'specs' bundle, too?
On Mon, Dec 14, 2015 at 10:27 AM, Benson Margulies <be...@basistech.com>
wrote:
> I didn't know. I assumed that the SM stuff was there for a reason. That
> will be my next port of call.
>
>
> On Mon, Dec 14, 2015 at 10:21 AM, Christian Schneider <
> notifications@github.com> wrote:
>
>> Why do you use the hibernate bundle from servicemix?
>> It looks like hibernate already provides a validator bundle:
>>
>> http://search.maven.org/#artifactdetails|org.hibernate|hibernate-validator-osgi|5.2.2.Final|pom
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/apache/cxf/pull/102#issuecomment-164464862>.
>>
>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by tomitribe-dev <gi...@git.apache.org>.
Github user tomitribe-dev commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-218430605
Build triggered. sha1 is original commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164474590
I think we should not create our own feature for hibernate. There is already one:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by benson-basis <gi...@git.apache.org>.
Github user benson-basis commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164460805
Oh, it works. it's just really ugly :-)
Look at the horrible proxy code.
On Sun, Dec 13, 2015 at 9:20 PM, Andriy Redko <no...@github.com>
wrote:
> @benson-basis <https://github.com/benson-basis> Interesting, I pulled out
> your PR / branch, run tests and all of them are passed:
>
> [image: test]
> <https://cloud.githubusercontent.com/assets/509855/11771492/32bf8a34-a1df-11e5-9e48-811cd749c24d.png>
>
> Any clues?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cxf/pull/102#issuecomment-164324664>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164492183
The change in BeanValidator looks good to me. I think it is just a workaround though. If hibernate needs el to work internally it should take care of importing it by itself. Maybe we should file this as a bug.
On the other hand providing a special classloader makes sense anyway as hibernate validator needs access to the user classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by benson-basis <gi...@git.apache.org>.
Github user benson-basis commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164473792
I think that what's here now should be digestible. No 'helper', no proxy, just a bit of TCCL juggling and import management required by the creator of the BeanValidationProvider instance. People who want to do that from Blueprint will be sad, I guess. Do people want some sort of factory?
If something better emerges from Hibernate later, great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by benson-basis <gi...@git.apache.org>.
Github user benson-basis commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164485180
I am entirely with you for 3.2.0. For 3.1.5 I just wanted to patch things
into working condition. What do you think of my smaller maneuver in
beanvalidationprovider?
On Dec 14, 2015 6:09 PM, "Christian Schneider" <no...@github.com>
wrote:
> Ah yes I see there are two wrap entries ... still I think this does not
> belong into cxf.
> I am especially concerned with the tight binding of the cxf validation to
> hibernate validator. I think CXF should be able to work with any validation
> provider and let the user choose which to install.
>
> How about adding a correct hibernate 5 feature without wrap into the
> upcoming karaf 4.0.4?
> I will take care of providing a fix to hibernate so their own feature is
> better in the next release.
>
> I propose we only have the cxf-bean-validation feature in CXF. We can load
> the validation api using dependency=true. This way it should nicely
> interoperate with the hibernate validator feature.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cxf/pull/102#issuecomment-164478366>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164464862
Why do you use the hibernate bundle from servicemix?
It looks like hibernate already provides a validator bundle:
http://search.maven.org/#artifactdetails|org.hibernate|hibernate-validator-osgi|5.2.2.Final|pom
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6706 hibernate help
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider commented on the pull request:
https://github.com/apache/cxf/pull/102#issuecomment-164492683
So anyway .. +1 for this change in CXF 3.1.x. I sometimes concentrate too much on the long term effects. For the bugfix release your changes make sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---