You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "924060929 (via GitHub)" <gi...@apache.org> on 2026/04/28 08:56:46 UTC
[PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
924060929 opened a new pull request, #62906:
URL: https://github.com/apache/doris/pull/62906
## Summary
- `IPv4Literal.parseIPv4toLong` silently returned `0L` for invalid input (e.g. `'not_an_ip'`), so `ColumnDef.validateDefaultValue` accepted any string as an IPv4 default value.
- Changed the three `return 0L` error paths to `throw AnalysisException`, matching the behavior of `IPv6Literal` which already rejects invalid defaults at DDL time.
- Added unit tests covering valid/invalid IPv4 literals and `ColumnDef.validateDefaultValue` for `Type.IPV4`.
## Test plan
- [x] `IPV4LiteralTest` — 4 tests pass (valid literals, invalid literals, validateDefaultValue valid/invalid)
- [ ] Verify `CREATE TABLE ... (ip IPV4 DEFAULT 'not_an_ip')` is rejected
- [ ] Verify `CREATE TABLE ... (ip IPV4 DEFAULT '192.168.0.1')` still works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4687023522
<details>
<summary>TPC-DS: <b>Total hot run time: 168168 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 24ccf04fa6f7ac21cff4818b829919f66448d4c0, data reload: false
query5 4316 615 474 474
query6 457 188 169 169
query7 4808 591 303 303
query8 357 212 203 203
query9 8745 3991 3963 3963
query10 459 312 247 247
query11 5760 2353 2151 2151
query12 152 100 97 97
query13 1249 597 420 420
query14 6373 5413 5026 5026
query14_1 4374 4386 4361 4361
query15 202 198 176 176
query16 1007 456 425 425
query17 1112 717 566 566
query18 2752 477 356 356
query19 203 185 148 148
query20 118 108 105 105
query21 215 140 117 117
query22 13674 13576 13434 13434
query23 17261 16511 16096 16096
query23_1 16329 16296 16186 16186
query24 7419 1761 1324 1324
query24_1 1319 1287 1336 1287
query25 560 450 391 391
query26 1307 319 161 161
query27 2645 563 349 349
query28 4456 2057 2060 2057
query29 1135 635 501 501
query30 303 226 198 198
query31 1128 1072 967 967
query32 118 66 57 57
query33 568 321 262 262
query34 1189 1121 663 663
query35 747 786 718 718
query36 1405 1370 1237 1237
query37 142 106 87 87
query38 3180 3132 3048 3048
query39 928 929 933 929
query39_1 876 864 883 864
query40 218 120 97 97
query41 63 76 58 58
query42 93 91 90 90
query43 314 318 272 272
query44
query45 193 185 180 180
query46 1087 1176 738 738
query47 2389 2318 2247 2247
query48 406 405 261 261
query49 639 462 353 353
query50 1009 352 246 246
query51 4267 4263 4243 4243
query52 87 87 75 75
query53 250 268 200 200
query54 266 213 188 188
query55 81 76 66 66
query56 257 216 214 214
query57 1419 1386 1312 1312
query58 243 208 202 202
query59 1565 1631 1397 1397
query60 270 237 217 217
query61 150 151 148 148
query62 686 647 579 579
query63 224 191 187 187
query64 2502 741 600 600
query65
query66 1733 458 337 337
query67 29571 29604 29476 29476
query68
query69 424 306 296 296
query70 1011 962 967 962
query71 286 218 202 202
query72 2873 2623 2325 2325
query73 853 771 418 418
query74 5088 4974 4771 4771
query75 2649 2570 2193 2193
query76 2362 1135 785 785
query77 341 374 276 276
query78 12517 12328 11777 11777
query79 1546 1071 785 785
query80 1270 440 385 385
query81 526 282 240 240
query82 603 155 121 121
query83 308 275 243 243
query84
query85 890 500 410 410
query86 425 318 291 291
query87 3401 3306 3264 3264
query88 3580 2722 2690 2690
query89 419 376 326 326
query90 1913 177 178 177
query91 171 156 134 134
query92 65 63 55 55
query93 1708 1466 832 832
query94 698 343 315 315
query95 652 453 338 338
query96 1040 771 325 325
query97 2713 2675 2559 2559
query98 219 210 205 205
query99 1126 1187 1035 1035
Total cold run time: 251425 ms
Total hot run time: 168168 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4687277752
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4687278694
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4687586792
<details>
<summary>TPC-DS: <b>Total hot run time: 169113 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b5dfb89f0b2c617f5190e9efacbd3083ff299a3d, data reload: false
query5 4318 602 473 473
query6 438 189 173 173
query7 4809 576 312 312
query8 358 210 195 195
query9 8753 4040 4006 4006
query10 441 300 260 260
query11 5971 2341 2158 2158
query12 151 100 95 95
query13 1265 609 431 431
query14 6393 5411 5060 5060
query14_1 4384 4357 4380 4357
query15 205 196 185 185
query16 1034 445 428 428
query17 1121 706 591 591
query18 2717 475 363 363
query19 207 184 150 150
query20 116 110 109 109
query21 212 139 119 119
query22 13697 13560 13367 13367
query23 17366 16572 16197 16197
query23_1 16346 16313 16256 16256
query24 7477 1765 1288 1288
query24_1 1289 1307 1308 1307
query25 565 438 371 371
query26 1310 303 165 165
query27 2622 566 343 343
query28 4421 2033 2021 2021
query29 1044 609 473 473
query30 299 234 198 198
query31 1117 1062 957 957
query32 103 60 59 59
query33 496 309 243 243
query34 1156 1089 665 665
query35 739 767 671 671
query36 1380 1371 1201 1201
query37 150 100 93 93
query38 3199 3126 3060 3060
query39 926 909 892 892
query39_1 873 892 866 866
query40 216 120 99 99
query41 62 61 59 59
query42 93 89 93 89
query43 313 316 274 274
query44
query45 191 186 180 180
query46 1074 1186 756 756
query47 2302 2395 2262 2262
query48 382 425 305 305
query49 613 457 339 339
query50 961 365 263 263
query51 4431 4293 4229 4229
query52 86 89 76 76
query53 251 255 188 188
query54 259 211 202 202
query55 81 74 68 68
query56 226 227 222 222
query57 1429 1438 1320 1320
query58 246 208 201 201
query59 1553 1627 1455 1455
query60 286 238 224 224
query61 149 143 149 143
query62 706 643 567 567
query63 216 184 181 181
query64 2505 782 600 600
query65
query66 1747 453 336 336
query67 29679 29678 29446 29446
query68
query69 416 289 281 281
query70 981 955 938 938
query71 288 221 215 215
query72 2888 2634 2320 2320
query73 830 769 428 428
query74 5156 4927 4796 4796
query75 2650 2580 2224 2224
query76 2314 1131 785 785
query77 355 373 290 290
query78 12371 12335 11895 11895
query79 1235 1023 747 747
query80 501 476 378 378
query81 447 278 238 238
query82 236 160 123 123
query83 268 274 248 248
query84
query85 803 522 419 419
query86 330 307 270 270
query87 3371 3331 3222 3222
query88 3670 2753 2733 2733
query89 405 383 331 331
query90 2140 166 176 166
query91 171 159 143 143
query92 64 57 50 50
query93 1408 1480 822 822
query94 528 334 323 323
query95 673 378 360 360
query96 1021 788 354 354
query97 2701 2697 2573 2573
query98 213 206 203 203
query99 1145 1193 1028 1028
Total cold run time: 249391 ms
Total hot run time: 169113 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4687537075
<details>
<summary>TPC-H: <b>Total hot run time: 29605 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b5dfb89f0b2c617f5190e9efacbd3083ff299a3d, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17590 4071 4078 4071
q2 q3 10801 1377 811 811
q4 4685 477 339 339
q5 7593 872 581 581
q6 186 181 139 139
q7 796 851 630 630
q8 9374 1657 1702 1657
q9 5753 4534 4531 4531
q10 6813 1823 1566 1566
q11 449 283 254 254
q12 627 431 313 313
q13 18120 3514 2819 2819
q14 264 276 263 263
q15 q16 821 779 714 714
q17 943 908 923 908
q18 7317 5868 5580 5580
q19 1555 1288 1148 1148
q20 509 404 271 271
q21 6296 2840 2675 2675
q22 471 380 335 335
Total cold run time: 100963 ms
Total hot run time: 29605 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 5212 4901 5074 4901
q2 q3 4953 5238 4722 4722
q4 2256 2248 1400 1400
q5 4925 4938 4782 4782
q6 246 192 136 136
q7 1853 1759 1589 1589
q8 2636 2239 2313 2239
q9 8080 7944 7522 7522
q10 4763 4644 4258 4258
q11 560 384 356 356
q12 742 737 535 535
q13 3063 3405 2839 2839
q14 277 314 258 258
q15 q16 697 703 612 612
q17 1306 1270 1266 1266
q18 7424 7105 6901 6901
q19 1130 1103 1076 1076
q20 2242 2257 1955 1955
q21 5381 4685 4567 4567
q22 513 468 438 438
Total cold run time: 58259 ms
Total hot run time: 52352 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4687603981
# FE UT Coverage Report
Increment line coverage `` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62906_b5dfb89f0b2c617f5190e9efacbd3083ff299a3d/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62906_b5dfb89f0b2c617f5190e9efacbd3083ff299a3d/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4590926282
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/582)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62906_2a445a9d5eda1793b732c5ce216f2b91be70593b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62906_2a445a9d5eda1793b732c5ce216f2b91be70593b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4592035206
<details>
<summary>TPC-DS: <b>Total hot run time: 171658 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2a445a9d5eda1793b732c5ce216f2b91be70593b, data reload: false
query5 4305 658 517 517
query6 341 221 211 211
query7 4247 569 326 326
query8 327 243 224 224
query9 8790 4065 4046 4046
query10 451 341 303 303
query11 5787 2319 2211 2211
query12 189 138 128 128
query13 1281 623 458 458
query14 6111 5454 5163 5163
query14_1 4454 4489 4465 4465
query15 217 208 189 189
query16 1010 502 440 440
query17 1160 757 619 619
query18 2577 483 348 348
query19 224 205 168 168
query20 155 137 130 130
query21 220 140 115 115
query22 13716 13566 13331 13331
query23 17289 16634 16298 16298
query23_1 16447 16437 16270 16270
query24 7416 1748 1318 1318
query24_1 1309 1292 1307 1292
query25 554 484 438 438
query26 1325 312 172 172
query27 2689 578 346 346
query28 4424 2007 2024 2007
query29 990 612 502 502
query30 309 238 201 201
query31 1119 1067 953 953
query32 102 78 76 76
query33 547 353 298 298
query34 1172 1136 664 664
query35 783 796 705 705
query36 1429 1420 1236 1236
query37 157 102 90 90
query38 3213 3176 3102 3102
query39 927 927 895 895
query39_1 885 888 864 864
query40 237 154 130 130
query41 65 62 61 61
query42 116 112 113 112
query43 328 332 293 293
query44
query45 217 206 209 206
query46 1105 1206 760 760
query47 2437 2456 2248 2248
query48 392 409 305 305
query49 632 520 398 398
query50 971 348 263 263
query51 4369 4342 4245 4245
query52 109 108 97 97
query53 257 286 207 207
query54 315 271 256 256
query55 95 91 86 86
query56 296 323 305 305
query57 1433 1428 1351 1351
query58 319 282 263 263
query59 1606 1671 1475 1475
query60 324 330 317 317
query61 160 150 158 150
query62 705 646 586 586
query63 247 200 211 200
query64 2409 822 641 641
query65
query66 1705 496 366 366
query67 29749 29643 29581 29581
query68
query69 474 346 303 303
query70 1024 966 1001 966
query71 339 277 271 271
query72 3032 2732 2457 2457
query73 838 816 419 419
query74 5128 4933 4781 4781
query75 2701 2606 2265 2265
query76 2306 1149 754 754
query77 404 420 354 354
query78 12426 12427 11880 11880
query79 1296 1060 774 774
query80 600 550 454 454
query81 453 281 252 252
query82 240 158 124 124
query83 270 275 251 251
query84 268 135 116 116
query85 899 607 536 536
query86 361 341 333 333
query87 3411 3354 3196 3196
query88 3662 2766 2745 2745
query89 421 397 347 347
query90 2188 187 182 182
query91 177 163 138 138
query92 81 80 74 74
query93 1390 1485 925 925
query94 547 351 315 315
query95 664 389 347 347
query96 1054 823 356 356
query97 2752 2739 2641 2641
query98 233 229 249 229
query99 1171 1166 1033 1033
Total cold run time: 253038 ms
Total hot run time: 171658 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62906:
URL: https://github.com/apache/doris/pull/62906#discussion_r3400337618
##########
fe/fe-catalog/src/main/java/org/apache/doris/analysis/IPv4Literal.java:
##########
@@ -56,24 +60,23 @@ protected IPv4Literal(IPv4Literal other) {
this.value = other.value;
}
- private static long parseIPv4toLong(String ipv4) {
- String[] parts = ipv4.split("\\.");
- if (parts.length != 4) {
- return 0L;
+ private static long parseIPv4toLong(String ipv4) throws AnalysisException {
+ // Validate with Guava's address parser (never does DNS) instead of a hand-rolled
+ // split, which used to accept malformed defaults such as "1.2.3.4." (trailing dot)
+ // or "1.2.+3.4" (signed octet) and let them through at CREATE TABLE time.
+ if (ipv4 == null || !InetAddresses.isInetAddress(ipv4)) {
+ throw new AnalysisException("Invalid IPv4 format: " + ipv4);
+ }
+ InetAddress address = InetAddresses.forString(ipv4);
+ // Guava resolves IPv4-mapped IPv6 (e.g. "::ffff:1.2.3.4") to an Inet4Address, so also
+ // require the canonical dotted-quad form to round-trip; only real IPv4 literals pass.
Review Comment:
This round-trip check now rejects leading-zero IPv4 defaults such as `010.000.000.001`, even though existing Doris IPv4 semantics treat them as valid decimal input and normalize them: the Nereids IPv4 literal regex accepts `[01]?[0-9][0-9]?`, and the BE cast regression suite expects both normal and strict casts of `010.000.000.001` to produce `10.0.0.1`. Because `ColumnDef.validateDefaultValue(Type.IPV4, ...)` runs before the original default string is persisted, `CREATE TABLE (... ip IPV4 DEFAULT '010.000.000.001')` is now rejected while the parallel IPv4 input paths accept the same value. This is distinct from the earlier malformed trailing-dot/signed-octet issue; those should still be rejected, but leading-zero octets need to remain accepted here or the parallel IPv4 semantics/tests need to be changed consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4590894093
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/582)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62906_2a445a9d5eda1793b732c5ce216f2b91be70593b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62906_2a445a9d5eda1793b732c5ce216f2b91be70593b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62906:
URL: https://github.com/apache/doris/pull/62906#discussion_r3387753268
##########
fe/fe-catalog/src/main/java/org/apache/doris/analysis/IPv4Literal.java:
##########
@@ -56,10 +56,10 @@ protected IPv4Literal(IPv4Literal other) {
this.value = other.value;
}
- private static long parseIPv4toLong(String ipv4) {
+ private static long parseIPv4toLong(String ipv4) throws AnalysisException {
String[] parts = ipv4.split("\\.");
Review Comment:
This still lets some invalid IPv4 defaults through. `String.split("\\.")` drops trailing empty tokens, so values like `1.2.3.4.` or `1.2.3.4..` are parsed as the four octets of `1.2.3.4`; `Short.parseShort` also accepts a leading `+`, so `1.2.+3.4` passes the loop. That means `ColumnDef.validateDefaultValue(Type.IPV4, ..., null)` can still accept malformed defaults at CREATE TABLE time, preserving the late-failure mode this PR is trying to close. The existing cast regression suite treats `1.2.+3.4` as invalid, and Nereids' IPv4 literal regex rejects these forms. Please make this legacy parser strict as well, for example by reusing the Nereids-style IPv4 regex or by using `split("\\.", -1)` plus digit-only octet validation, and add unit coverage for those cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4686843705
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4687138642
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4687547015
<details>
<summary>TPC-H: <b>Total hot run time: 29143 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2b07998efa79cac901d09279bfe5ee8d057acd13, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17867 4117 4025 4025
q2 q3 10767 1433 801 801
q4 4683 470 345 345
q5 7530 896 596 596
q6 192 169 143 143
q7 791 855 618 618
q8 9978 1645 1679 1645
q9 6797 4550 4554 4550
q10 6769 1836 1531 1531
q11 438 267 261 261
q12 643 427 297 297
q13 18147 3457 2817 2817
q14 276 260 237 237
q15 q16 812 774 700 700
q17 1002 918 946 918
q18 7046 5639 5483 5483
q19 1186 1243 1087 1087
q20 499 429 254 254
q21 5877 2805 2510 2510
q22 465 383 325 325
Total cold run time: 101765 ms
Total hot run time: 29143 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4970 4751 4740 4740
q2 q3 5103 5244 4653 4653
q4 2139 2268 1435 1435
q5 4908 4893 4677 4677
q6 241 175 134 134
q7 1830 1742 1507 1507
q8 2391 2142 1933 1933
q9 7402 7387 7451 7387
q10 4783 4720 4210 4210
q11 546 382 355 355
q12 724 739 529 529
q13 3106 3446 2860 2860
q14 284 282 249 249
q15 q16 676 699 604 604
q17 1278 1258 1246 1246
q18 7429 6880 6794 6794
q19 1164 1110 1085 1085
q20 2255 2224 1934 1934
q21 5331 4690 4529 4529
q22 530 459 405 405
Total cold run time: 57090 ms
Total hot run time: 51266 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4591961116
<details>
<summary>TPC-H: <b>Total hot run time: 29313 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2a445a9d5eda1793b732c5ce216f2b91be70593b, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17796 4015 3984 3984
q2 q3 10774 1421 808 808
q4 4685 482 342 342
q5 7577 866 597 597
q6 181 168 135 135
q7 752 846 638 638
q8 9391 1565 1631 1565
q9 5816 4547 4538 4538
q10 6754 1796 1543 1543
q11 438 272 247 247
q12 621 432 288 288
q13 18112 3302 2789 2789
q14 266 258 233 233
q15 q16 819 781 713 713
q17 886 945 872 872
q18 6835 5679 5561 5561
q19 1344 1203 1098 1098
q20 540 395 266 266
q21 6375 2802 2788 2788
q22 449 375 308 308
Total cold run time: 100411 ms
Total hot run time: 29313 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 5076 4826 4847 4826
q2 q3 4901 5374 4657 4657
q4 2117 2201 1414 1414
q5 4829 4651 4943 4651
q6 240 173 124 124
q7 1902 1739 1616 1616
q8 2463 2155 2079 2079
q9 8071 7911 7603 7603
q10 4730 4695 4258 4258
q11 541 384 356 356
q12 730 743 532 532
q13 3012 3309 2765 2765
q14 271 278 255 255
q15 q16 691 694 608 608
q17 1266 1247 1264 1247
q18 7199 6712 6736 6712
q19 1111 1102 1084 1084
q20 2218 2205 1945 1945
q21 5309 4604 4496 4496
q22 513 470 435 435
Total cold run time: 57190 ms
Total hot run time: 51663 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4668355251
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4686846388
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4687597128
<details>
<summary>TPC-DS: <b>Total hot run time: 169841 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2b07998efa79cac901d09279bfe5ee8d057acd13, data reload: false
query5 4340 635 498 498
query6 427 185 171 171
query7 4913 589 297 297
query8 365 217 202 202
query9 8747 4083 4044 4044
query10 457 316 247 247
query11 5937 2375 2154 2154
query12 150 101 95 95
query13 1285 620 431 431
query14 6566 5417 5084 5084
query14_1 4420 4406 4382 4382
query15 206 198 179 179
query16 986 455 350 350
query17 1108 696 581 581
query18 2715 480 348 348
query19 201 185 146 146
query20 121 109 105 105
query21 223 138 114 114
query22 13736 13757 13405 13405
query23 17590 16440 16197 16197
query23_1 16331 16211 16182 16182
query24 7712 1781 1294 1294
query24_1 1306 1332 1324 1324
query25 559 462 390 390
query26 1332 330 171 171
query27 2578 532 348 348
query28 4437 2074 2055 2055
query29 1109 617 493 493
query30 310 235 208 208
query31 1153 1062 958 958
query32 107 59 58 58
query33 501 294 242 242
query34 1184 1112 659 659
query35 744 775 685 685
query36 1397 1440 1256 1256
query37 153 106 85 85
query38 3219 3113 3085 3085
query39 938 923 908 908
query39_1 869 891 863 863
query40 221 123 98 98
query41 63 63 63 63
query42 93 93 94 93
query43 325 322 276 276
query44
query45 191 185 177 177
query46 1079 1203 720 720
query47 2366 2327 2248 2248
query48 391 424 305 305
query49 612 462 368 368
query50 960 357 272 272
query51 4353 4332 4297 4297
query52 88 88 76 76
query53 249 266 187 187
query54 266 208 191 191
query55 78 73 69 69
query56 226 217 211 211
query57 1454 1411 1296 1296
query58 246 226 200 200
query59 1573 1635 1438 1438
query60 281 240 226 226
query61 151 149 148 148
query62 706 637 587 587
query63 230 190 188 188
query64 2492 768 623 623
query65
query66 1756 471 338 338
query67 30158 29840 29750 29750
query68
query69 398 300 249 249
query70 961 930 926 926
query71 290 227 205 205
query72 2983 2728 2358 2358
query73 815 742 414 414
query74 5118 4960 4766 4766
query75 2651 2594 2231 2231
query76 2370 1178 764 764
query77 339 385 290 290
query78 12508 12425 11953 11953
query79 1394 1059 779 779
query80 586 457 395 395
query81 448 278 247 247
query82 585 154 118 118
query83 348 276 245 245
query84
query85 860 501 405 405
query86 355 300 283 283
query87 3410 3384 3207 3207
query88 3674 2755 2750 2750
query89 427 384 322 322
query90 1886 174 172 172
query91 169 153 130 130
query92 64 59 55 55
query93 1586 1595 939 939
query94 542 345 299 299
query95 687 369 357 357
query96 1098 778 359 359
query97 2704 2708 2578 2578
query98 209 209 200 200
query99 1156 1183 1033 1033
Total cold run time: 251800 ms
Total hot run time: 169841 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4333776215
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4689688866
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/59)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62906_2b07998efa79cac901d09279bfe5ee8d057acd13_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62906_2b07998efa79cac901d09279bfe5ee8d057acd13_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62906:
URL: https://github.com/apache/doris/pull/62906#discussion_r3400530989
##########
fe/fe-catalog/src/main/java/org/apache/doris/analysis/IPv4Literal.java:
##########
@@ -56,22 +56,33 @@ protected IPv4Literal(IPv4Literal other) {
this.value = other.value;
}
- private static long parseIPv4toLong(String ipv4) {
- String[] parts = ipv4.split("\\.");
+ private static long parseIPv4toLong(String ipv4) throws AnalysisException {
+ // Use limit -1 so a trailing dot keeps its empty part: "1.2.3.4." stays 5 parts and is
+ // rejected by the count check below (plain split("\\.") drops the trailing "" and would
+ // wrongly yield 4). A leading or inner empty part keeps 4 parts and is instead rejected
+ // when Short.parseShort throws on the empty octet.
+ String[] parts = ipv4.split("\\.", -1);
if (parts.length != 4) {
- return 0L;
+ throw new AnalysisException("Invalid IPv4 format: " + ipv4);
}
long value = 0L;
for (int i = 0; i < 4; ++i) {
+ // Short.parseShort accepts a leading '+' (e.g. "+3"), which is not a valid octet,
+ // so reject it explicitly. A leading '-' / out-of-range value is caught by the
+ // range check below, and any other non-digit makes parseShort throw. Leading zeros
+ // stay decimal ("010" -> 10), consistent with the BE parser.
+ if (parts[i].startsWith("+")) {
Review Comment:
`Short.parseShort` is still too permissive for this DDL validator: Java accepts Unicode decimal digits, so `ColumnDef.validateDefaultValue(Type.IPV4, "１２７.０.０.１", null)` succeeds here. The column then stores/sends the original default string (`Column.defaultValue`/`ColumnToThrift`), and BE later parses defaults through `DataTypeIPv4SerDe` -> `CastToIPv4`, whose `parse_ipv4` only accepts ASCII `0`-`9`; that default fails during default materialization instead of at CREATE TABLE time. This is distinct from the existing trailing-dot/signed-octet thread: those examples are fixed, but the parser still is not ASCII digit-only. Please validate each octet is non-empty ASCII digits before `Short.parseShort` (keeping leading zeros decimal) and add a negative test for Unicode digits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4688386993
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4590095567
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4590531884
# FE UT Coverage Report
Increment line coverage `` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62906_2a445a9d5eda1793b732c5ce216f2b91be70593b/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62906_2a445a9d5eda1793b732c5ce216f2b91be70593b/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 merged PR #62906:
URL: https://github.com/apache/doris/pull/62906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4687138297
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4686977201
<details>
<summary>TPC-H: <b>Total hot run time: 28899 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 24ccf04fa6f7ac21cff4818b829919f66448d4c0, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17655 4057 4007 4007
q2 q3 10764 1322 814 814
q4 4690 468 338 338
q5 7541 853 588 588
q6 179 167 133 133
q7 765 847 613 613
q8 10240 1578 1516 1516
q9 6862 4518 4468 4468
q10 6859 1801 1505 1505
q11 432 270 253 253
q12 630 424 284 284
q13 18185 3373 2740 2740
q14 259 253 241 241
q15 q16 819 770 710 710
q17 906 893 927 893
q18 6812 5671 5546 5546
q19 1286 1228 1092 1092
q20 510 400 259 259
q21 5977 2844 2587 2587
q22 454 373 312 312
Total cold run time: 101825 ms
Total hot run time: 28899 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4838 4629 4625 4625
q2 q3 5101 5271 4617 4617
q4 2093 2192 1389 1389
q5 4800 4867 4684 4684
q6 250 178 129 129
q7 1870 1695 1578 1578
q8 2402 1949 1910 1910
q9 7396 7466 7338 7338
q10 4736 4679 4210 4210
q11 529 380 349 349
q12 732 743 520 520
q13 2947 3270 2796 2796
q14 267 275 250 250
q15 q16 671 686 610 610
q17 1276 1253 1233 1233
q18 7317 6765 6782 6765
q19 1107 1086 1114 1086
q20 2215 2215 1953 1953
q21 5193 4531 4356 4356
q22 524 453 406 406
Total cold run time: 56264 ms
Total hot run time: 50804 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ddl) reject invalid IPv4 default value at CREATE TABLE time [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62906:
URL: https://github.com/apache/doris/pull/62906#issuecomment-4689075192
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/7)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62906_2b07998efa79cac901d09279bfe5ee8d057acd13_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62906_2b07998efa79cac901d09279bfe5ee8d057acd13_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org