You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by we...@apache.org on 2019/10/02 21:38:16 UTC
[hadoop] branch branch-3.1 updated: HDFS-14610. HashMap is not
thread safe. Field storageMap is typically synchronized by storageMap.
However, in one place,
field storageMap is not protected with synchronized. (#1015)
This is an automated email from the ASF dual-hosted git repository.
weichiu pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.1 by this push:
new d95dd33 HDFS-14610. HashMap is not thread safe. Field storageMap is typically synchronized by storageMap. However, in one place, field storageMap is not protected with synchronized. (#1015)
d95dd33 is described below
commit d95dd33ea115cb3fba25688279a5c9bbaa769da9
Author: paulward24 <52...@users.noreply.github.com>
AuthorDate: Mon Jul 1 13:54:49 2019 -0700
HDFS-14610. HashMap is not thread safe. Field storageMap is typically synchronized by storageMap. However, in one place, field storageMap is not protected with synchronized. (#1015)
(cherry picked from commit d8bac50e12d243ef8fd2c7e0ce5c9997131dee74)
(cherry picked from commit 76a91359475444cb6d415e5056430c0e743b88ee)
---
.../hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
index 46a4a7e..a4e43f2 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
@@ -451,8 +451,11 @@ public class DatanodeDescriptor extends DatanodeInfo {
this.volumeFailureSummary = volumeFailureSummary;
for (StorageReport report : reports) {
- DatanodeStorageInfo storage =
- storageMap.get(report.getStorage().getStorageID());
+ DatanodeStorageInfo storage = null;
+ synchronized (storageMap) {
+ storage =
+ storageMap.get(report.getStorage().getStorageID());
+ }
if (checkFailedStorages) {
failedStorageInfos.remove(storage);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org