You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/12/17 03:58:33 UTC

[GitHub] [incubator-pinot] kkrugler opened a new issue #6364: Fix logging dependencies in pinot-spi

kkrugler opened a new issue #6364:
URL: https://github.com/apache/incubator-pinot/issues/6364


   pinot-spi’s pom has a dependency on `log4j-slf4j-impl`. I don’t think this is right - it should only depend on `slf4j-api`. Because of the current dependency, the pinot-java-client’s dependency on pinot-spi pulls in the logging implementation, which is not what you want because it means an external project using the client often needs to exclude those logging jars.
   
   I'm guessing there are other components with a similar issue - only jars that are run from the command line should have dependencies on log4j-slf4j-impl, and include log4j2 configuration resources.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org