You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2023/02/25 04:22:18 UTC
[GitHub] [flink] slfan1989 opened a new pull request, #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
slfan1989 opened a new pull request, #22020:
URL: https://github.com/apache/flink/pull/22020
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
JIRA: FLINK-31222. Remove usage of deprecated ConverterUtils.toApplicationId.
When reading the code, I found that we use ConverterUtils.toApplicationId to convert applicationId, this method is deprecated, we should use ApplicationId.fromString
## Brief change log
Remove usage of deprecated ConverterUtils.toApplicationId.
## Verifying this change
Manually verified.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1448129413
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1449401392
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1449296895
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1445279697
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui merged pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #22020:
URL: https://github.com/apache/flink/pull/22020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1449306495
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1449661411
> Hi @slfan1989 , could you rebase the master branch? I see other CI works well, and your change shouldn't affect the CI.
@1996fanrui Thanks for your suggestion! I rebase the code and it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1447666600
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1449282757
Hi @slfan1989 , could you rebase the master branch? I see other CI works well, and your change shouldn't affect the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1445656410
Hi @slfan1989 , thanks for your contribution, please run `mvn spotless:apply` to fix the checkstyle.
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=46536&view=logs&j=b59e5554-36c7-5512-ab1a-b80b74075fce&t=849d419c-1b8f-52b7-e455-d4bc36ec43ad&l=16095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1445629495
@1996fanrui Can you help review this pr? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1447654008
@1996fanrui Can you help to review this PR again? Thank you very much!
```
--2023-02-28 03:11:51-- http://security.ubuntu.com/ubuntu/pool/main/o/openssl1.0/libssl1.0.0_1.0.2n-1ubuntu5.10_amd64.deb
Resolving security.ubuntu.com (security.ubuntu.com)... 185.125.190.39, 185.125.190.36, 91.189.91.39, ...
Connecting to security.ubuntu.com (security.ubuntu.com)|185.125.190.39|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2023-02-28 03:11:51 ERROR 404: Not Found.
```
The error is not caused by the code of this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1447322665
@1996fanrui Thank you very much for your help to review the code, I resubmitted the code, but azure cannot be triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1447250979
@flinkbot run azure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1449087453
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1445045660
@wuchong Can you help review this pr? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1447768293
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1444987349
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b7d8dcf55db34003ac5296887facfc6e5a8ce48",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4b7d8dcf55db34003ac5296887facfc6e5a8ce48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b7d8dcf55db34003ac5296887facfc6e5a8ce48 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #22020:
URL: https://github.com/apache/flink/pull/22020#issuecomment-1451507843
@1996fanrui Thank you very much for your help in reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org