You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/24 10:24:31 UTC

[GitHub] [bookkeeper] massakam opened a new pull request, #3356: BP-41 Add flag to enable/disable BookieAddressResolver

massakam opened a new pull request, #3356:
URL: https://github.com/apache/bookkeeper/pull/3356

   ### Motivation
   
   With BP-41, the BookKeeper client now needs a request to ZooKeeper to resolve the address from each bookie ID.
   
   In the following document, there is a description of the flag `enableBookieAddressResolver` for disabling this feature by regarding the bookie ID as an address or hostname, but it seems that this has not been implemented yet.
   https://github.com/apache/bookkeeper/blob/master/site3/website/src/pages/bps/BP-41-bookieid.md
   
   I implemented this because I want this flag to reduce the number of requests to ZK.
   
   ### Changes
   
   Added a flag named `enableBookieAddressResolver` to the client configuration. If this flag is false, use `BookieAddressResolverDisabled` instead of `DefaultBookieAddressResolver` as the address resolver for bookies. `BookieAddressResolverDisabled` regards a bookie ID to be in legacy format, i.e. "address:port" or "hostname:port", and returns the address of that bookie without access to ZK.
   
   Master Issue: #2396


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on a diff in pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on code in PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#discussion_r930663432


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java:
##########
@@ -1288,6 +1289,33 @@ public ClientConfiguration setEnsemblePlacementPolicySlowBookies(boolean enabled
         return this;
     }
 
+    /**
+     * Whether to enable BookieAddressResolver.
+     *
+     * @return flag to enable/disable BookieAddressResolver.
+     */
+    public boolean getEnableBookieAddressResolver() {

Review Comment:
   @StevenLuMT The `bookieAddressResolverEnabled` added this time is a client-side setting, so it cannot be set for `ServerConfiguration`. I replaced `ServerConfiguration` with `ClientConfiguration` because I want to test the behavior of `bookieAddressResolverEnabled` when it is true and when it is false.
   
   Also, I think that `ClientConfiguration` is more appropriate than `ServerConfiguration` to pass as the first argument of `DiscoveryCommand#apply()`.
   https://github.com/apache/bookkeeper/blob/62cfc0ec8670cb66ce4bf2b0d707f42cba5e3354/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/helpers/DiscoveryCommand.java#L49
   
   Even if `ServerConfiguration` is passed, it will be converted to `ClientConfiguration` internally.
   https://github.com/apache/bookkeeper/blob/62cfc0ec8670cb66ce4bf2b0d707f42cba5e3354/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/helpers/ClientCommand.java#L57-L61



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on code in PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#discussion_r929159189


##########
tools/ledger/src/test/java/org/apache/bookkeeper/tools/cli/helpers/DiscoveryCommandTest.java:
##########
@@ -62,17 +64,23 @@ public void setup() throws Exception {
 
         this.cmd = mock(DiscoveryCommand.class, CALLS_REAL_METHODS);
 
-        this.serverConf = new ServerConfiguration();
-        this.serverConf.setMetadataServiceUri("zk://127.0.0.1/path/to/ledgers");
+        this.clientConf = new ClientConfiguration();

Review Comment:
   why change ServerConfiguration to ClientConfiguration?
   



##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java:
##########
@@ -1288,6 +1289,33 @@ public ClientConfiguration setEnsemblePlacementPolicySlowBookies(boolean enabled
         return this;
     }
 
+    /**
+     * Whether to enable BookieAddressResolver.
+     *
+     * @return flag to enable/disable BookieAddressResolver.
+     */
+    public boolean getEnableBookieAddressResolver() {

Review Comment:
   old code style is getBookieAddressResolverEnable 
   I think it's better



##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java:
##########
@@ -1288,6 +1289,33 @@ public ClientConfiguration setEnsemblePlacementPolicySlowBookies(boolean enabled
         return this;
     }
 
+    /**
+     * Whether to enable BookieAddressResolver.
+     *
+     * @return flag to enable/disable BookieAddressResolver.
+     */
+    public boolean getEnableBookieAddressResolver() {
+        return getBoolean(ENABLE_BOOKIE_ADDRESS_RESOLVER, true);
+    }
+
+    /**
+     * Enable/Disable BookieAddressResolver.
+     *
+     * <p>
+     * If this flag is true, read bookie information from the metadata service (e.g. ZooKeeper) to resolve the address
+     * from each bookie ID. If all bookie IDs in the cluster are "address:port" or "hostname:port", you can set this
+     * flag to false to reduce requests to the metadata service.
+     * </p>
+     *
+     * @param enabled
+     *          flag to enable/disable BookieAddressResolver.
+     * @return client configuration.
+     */
+    public ClientConfiguration setEnableBookieAddressResolver(boolean enabled) {

Review Comment:
   setBookieAddressResolverEnable 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#discussion_r930666052


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieAddressResolverDisabled.java:
##########
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bookkeeper.client;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.bookkeeper.net.BookieId;
+import org.apache.bookkeeper.net.BookieSocketAddress;
+import org.apache.bookkeeper.proto.BookieAddressResolver;
+
+/**
+ * Resolve legacy style BookieIDs to Network addresses.
+ */
+@Slf4j
+public class BookieAddressResolverDisabled implements BookieAddressResolver {

Review Comment:
   final ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on a diff in pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on code in PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#discussion_r930665032


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java:
##########
@@ -1288,6 +1289,33 @@ public ClientConfiguration setEnsemblePlacementPolicySlowBookies(boolean enabled
         return this;
     }
 
+    /**
+     * Whether to enable BookieAddressResolver.
+     *
+     * @return flag to enable/disable BookieAddressResolver.
+     */
+    public boolean getEnableBookieAddressResolver() {

Review Comment:
   @StevenLuMT Renamed to "getBookieAddressResolverEnable**d**". What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on a diff in pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on code in PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#discussion_r930663755


##########
tools/ledger/src/test/java/org/apache/bookkeeper/tools/cli/helpers/DiscoveryCommandTest.java:
##########
@@ -62,17 +64,23 @@ public void setup() throws Exception {
 
         this.cmd = mock(DiscoveryCommand.class, CALLS_REAL_METHODS);
 
-        this.serverConf = new ServerConfiguration();
-        this.serverConf.setMetadataServiceUri("zk://127.0.0.1/path/to/ledgers");
+        this.clientConf = new ClientConfiguration();

Review Comment:
   @StevenLuMT The `bookieAddressResolverEnabled` added this time is a client-side setting, so it cannot be set for `ServerConfiguration`. I replaced `ServerConfiguration` with `ClientConfiguration` because I want to test the behavior of `bookieAddressResolverEnabled` when it is true and when it is false.
   
   Also, I think that `ClientConfiguration` is more appropriate than `ServerConfiguration` to pass as the first argument of `DiscoveryCommand#apply()`.
   https://github.com/apache/bookkeeper/blob/62cfc0ec8670cb66ce4bf2b0d707f42cba5e3354/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/helpers/DiscoveryCommand.java#L49
   
   Even if `ServerConfiguration` is passed, it will be converted to `ClientConfiguration` internally.
   https://github.com/apache/bookkeeper/blob/62cfc0ec8670cb66ce4bf2b0d707f42cba5e3354/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/helpers/ClientCommand.java#L57-L61



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1165742169

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1166200614

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1165614862

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1165718185

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1166194948

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1165674191

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1166181384

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1165763363

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1196316946

   PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] hangc0276 merged pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
hangc0276 merged PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on a diff in pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on code in PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#discussion_r930851380


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieAddressResolverDisabled.java:
##########
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bookkeeper.client;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.bookkeeper.net.BookieId;
+import org.apache.bookkeeper.net.BookieSocketAddress;
+import org.apache.bookkeeper.proto.BookieAddressResolver;
+
+/**
+ * Resolve legacy style BookieIDs to Network addresses.
+ */
+@Slf4j
+public class BookieAddressResolverDisabled implements BookieAddressResolver {

Review Comment:
   @eolivelli Added final modifier. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1196264570

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1166197972

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on a diff in pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on code in PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#discussion_r930666005


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java:
##########
@@ -1288,6 +1289,33 @@ public ClientConfiguration setEnsemblePlacementPolicySlowBookies(boolean enabled
         return this;
     }
 
+    /**
+     * Whether to enable BookieAddressResolver.
+     *
+     * @return flag to enable/disable BookieAddressResolver.
+     */
+    public boolean getEnableBookieAddressResolver() {
+        return getBoolean(ENABLE_BOOKIE_ADDRESS_RESOLVER, true);
+    }
+
+    /**
+     * Enable/Disable BookieAddressResolver.
+     *
+     * <p>
+     * If this flag is true, read bookie information from the metadata service (e.g. ZooKeeper) to resolve the address
+     * from each bookie ID. If all bookie IDs in the cluster are "address:port" or "hostname:port", you can set this
+     * flag to false to reduce requests to the metadata service.
+     * </p>
+     *
+     * @param enabled
+     *          flag to enable/disable BookieAddressResolver.
+     * @return client configuration.
+     */
+    public ClientConfiguration setEnableBookieAddressResolver(boolean enabled) {

Review Comment:
   Renamed to "setBookieAddressResolverEnable**d**".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1165593080

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1166191019

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1165567703

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] massakam commented on pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

Posted by GitBox <gi...@apache.org>.
massakam commented on PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#issuecomment-1166184925

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org