You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "EgorKuts (via GitHub)" <gi...@apache.org> on 2025/10/13 13:44:06 UTC
[PR] IGNITE-26624 Improve error message when thin client connects to unini… [ignite-3]
EgorKuts opened a new pull request, #6755:
URL: https://github.com/apache/ignite-3/pull/6755
https://issues.apache.org/jira/browse/IGNITE-26624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26624 Improve error message when thin client connects to unini… [ignite-3]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 merged PR #6755:
URL: https://github.com/apache/ignite-3/pull/6755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26624 Improve error message when thin client connects to unini… [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #6755:
URL: https://github.com/apache/ignite-3/pull/6755#discussion_r2426452342
##########
modules/client/src/main/java/org/apache/ignite/internal/client/TcpClientChannel.java:
##########
@@ -665,9 +680,12 @@ private CompletableFuture<Object> handshakeAsync(ProtocolVersion ver) throws Ign
metrics.handshakesFailedTimeoutIncrement();
throw new IgniteClientConnectionException(CONNECTION_ERR, "Handshake timeout", endpoint(), err);
}
-
metrics.handshakesFailedIncrement();
- throw new IgniteClientConnectionException(CONNECTION_ERR, "Handshake error", endpoint(), err);
+ if (err.getCause() instanceof IgniteClientConnectionException) {
+ throw (IgniteClientConnectionException) err.getCause();
Review Comment:
We should never re-throw something that was thrown before, it screws up the stack trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26624 Improve error message when thin client connects to unini… [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #6755:
URL: https://github.com/apache/ignite-3/pull/6755#discussion_r2428990342
##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/sql/ItSqlConnectSslBasicTest.java:
##########
@@ -80,7 +80,7 @@ void jdbcFailWithoutBasicConfiguredAfterConnect() {
assertAll(
this::assertOutputIsEmpty,
() -> assertErrOutputContains("Connection failed"),
- () -> assertErrOutputContains("Handshake error")
+ () -> assertErrOutputContains("Channel is closed")
Review Comment:
"Handshake error" was better, I think - can we restore it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org