You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Crazylychee (via GitHub)" <gi...@apache.org> on 2025/04/10 13:51:37 UTC

[PR] [ISSUES #281 #274 #285] Speeds up topic and consumer queries, adds caching, and fixes delay/dead-letter topic mix-up [rocketmq-dashboard]

Crazylychee opened a new pull request, #286:
URL: https://github.com/apache/rocketmq-dashboard/pull/286

   ## What is the purpose of the change
   
   #281 #274 #285
   
   ## Brief changelog
   
   The existing code for querying topics and consumers in the old version has a lot of redundant operations and repeated queries, which can easily lead to timeouts and errors when dealing with large data volumes. This PR mainly optimizes the speed of querying topics and consumers. Additionally, due to the longer time required to query consumers, caching is used to optimize the speed of the second query, and an option to refresh individual entries is provided. It also resolves the issue of confusion between delay topics and dead-letter topics.
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   /
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUES #281 #274 #285 #287] Speeds up topic and consumer queries, adds caching, and fixes delay/dead-letter topic mix-up [rocketmq-dashboard]

Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #286:
URL: https://github.com/apache/rocketmq-dashboard/pull/286


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org