You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/10/13 22:14:17 UTC
[GitHub] [datasketches-cpp] AlexanderSaydakov opened a new pull request #246: use default allocator for temporary ostringstream
AlexanderSaydakov opened a new pull request #246:
URL: https://github.com/apache/datasketches-cpp/pull/246
This is to address the problem that std::ostringstream does not support passing an allocator instance. A custom allocator might not have a default constructor. The proposed approach does not comply with AllocatorAwareContainer requirements, but neither does the current approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov merged pull request #246: use default allocator for temporary ostringstream
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged pull request #246:
URL: https://github.com/apache/datasketches-cpp/pull/246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls commented on pull request #246: use default allocator for temporary ostringstream
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #246:
URL: https://github.com/apache/datasketches-cpp/pull/246#issuecomment-942763506
## Pull Request Test Coverage Report for [Build 1339463093](https://coveralls.io/builds/43489995)
* **0** of **4** **(0.0%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **92.769%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [tuple/include/tuple_sketch_impl.hpp](https://coveralls.io/builds/43489995/source?filename=tuple%2Finclude%2Ftuple_sketch_impl.hpp#L243) | 0 | 1 | 0.0%
| [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/43489995/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L64) | 0 | 3 | 0.0%
<!-- | **Total:** | **0** | **4** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/43489995) |
| :-- | --: |
| Change from base [Build 1317592223](https://coveralls.io/builds/43351680): | 0.0% |
| Covered Lines: | 2181 |
| Relevant Lines: | 2351 |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org