Re: [PR] FINERACT-2714: Add ability to exclude closed clients from client search results [fineract]

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy commented on PR #6188:
URL: https://github.com/apache/fineract/pull/6188#issuecomment-5165492678

   > Thanks for the review! The scope here is intentionally narrow: this maps to a single UI checkbox — "Exclude closed accounts" — on the client search screen, not a general-purpose client-status filter.
   > 
   > The intent is just to let users hide closed clients from search results by default, since closed accounts otherwise clutter results for users who are typically looking for active/actionable clients. It isn't meant to generalize into filtering by arbitrary client status (pending, rejected, withdrawn, etc.) — that would be a bigger, separate feature with its own UI/UX (e.g. a status multi-select) and API design considerations, and isn't what this fix was scoped to solve.
   
   I agree with @IOhacker. From a backend perspective, filtering by status would make more sense. I suggest adding a “status” filter, where the caller can select the statuses they’re interested in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org