[GitHub] [superset] etr2460 commented on a change in pull request #19138: fix: Remove gap from SQLLab results bottom

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #19138:
URL: https://github.com/apache/superset/pull/19138#discussion_r826553423



##########
File path: superset-frontend/src/SqlLab/components/SouthPane/index.tsx
##########
@@ -152,7 +152,7 @@ export default function SouthPane({
             query={latestQuery}
             actions={actions}
             user={user}
-            height={innerTabContentHeight}
+            height={innerTabContentHeight + 24}

Review comment:
       could we add this to a constant at the top of the file? and explain in code why this is needed?
   
   Alternatively, where does innerTabContentHeight come from? Is there some alteration that needs to be made there instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org