You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/10/09 18:03:27 UTC

svn commit: r1894078 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/SignatureOptions.java

Author: tilman
Date: Sat Oct  9 18:03:27 2021
New Revision: 1894078

URL: http://svn.apache.org/viewvc?rev=1894078&view=rev
Log:
PDFBOX-4892: dispose pdfSource even if visualSignature.close() will throw exception, as suggested by valerybokov

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/SignatureOptions.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/SignatureOptions.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/SignatureOptions.java?rev=1894078&r1=1894077&r2=1894078&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/SignatureOptions.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/SignatureOptions.java Sat Oct  9 18:03:27 2021
@@ -157,13 +157,19 @@ public class SignatureOptions implements
     @Override
     public void close() throws IOException
     {
-        if (visualSignature != null)
+        try
         {
-            visualSignature.close();
+            if (visualSignature != null)
+            {
+                visualSignature.close();
+            }
         }
-        if (pdfSource != null)
+        finally
         {
-            pdfSource.close();
+            if (pdfSource != null)
+            {
+                pdfSource.close();
+            }
         }
     }
 }